Changes after code review

aws · May 21, 2020 · 5e9e726 · 5e9e726
1 parent b076d70
commit 5e9e726
Show file tree

Hide file tree

Showing 5 changed files with 353 additions and 78 deletions.
diff --git a/packages/@aws-cdk/aws-eks/lib/cluster.ts b/packages/@aws-cdk/aws-eks/lib/cluster.ts
@@ -708,7 +708,7 @@ export class Cluster extends Resource implements ICluster {
    * @param id the id of this service account
    * @param options service account options
    */
-  public addServiceAccount(id: string, options?: ServiceAccountOptions) {
+  public addServiceAccount(id: string, options: ServiceAccountOptions = { }) {
     return new ServiceAccount(this, id, {
       ...options,
       cluster: this,

diff --git a/packages/@aws-cdk/aws-eks/lib/irsa-conditions/external.ts b/packages/@aws-cdk/aws-eks/lib/irsa-conditions/external.ts
diff --git a/packages/@aws-cdk/aws-eks/lib/irsa-conditions/index.ts b/packages/@aws-cdk/aws-eks/lib/irsa-conditions/index.ts
diff --git a/packages/@aws-cdk/aws-eks/lib/service-account.ts b/packages/@aws-cdk/aws-eks/lib/service-account.ts
@@ -34,12 +34,6 @@ export interface ServiceAccountProps extends ServiceAccountOptions {
  * Service Account
  */
 export class ServiceAccount extends Construct implements IPrincipal {
-
-  /**
-   * The CloudFormation resource type.
-   */
-  public static readonly RESOURCE_TYPE = 'Custom::AWSCDK-EKS-IRSAConditions';
-
   /**
    * The role which is linked to the service account.
    */