Skip to content

Commit

Permalink
feat(rds): specify PreferredMaintenanceWindow in reader or writer pro…
Browse files Browse the repository at this point in the history
…ps (#29686)

### Issue #29687 

Closes ##29687 

### Reason for this change

Since `instanceProps` is deprecated it is better to allow setting `PreferredMaintenanceWindow` using writer and readers props.

### Description of changes

Added optional preferredMaintenanceWindow field to ClusterInstanceOptions and added a unit test.

### Description of how you validated changes

- Add a single unit test

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
Konosh93 authored Apr 5, 2024
1 parent 2814011 commit 615ee2d
Show file tree
Hide file tree
Showing 12 changed files with 237 additions and 141 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,7 @@
"Ref": "DatabaseSubnets56F17B9A"
},
"Engine": "aurora-mysql",
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
"PubliclyAccessible": true
},
"DependsOn": [
Expand Down Expand Up @@ -569,6 +570,7 @@
"Ref": "DatabaseSubnets56F17B9A"
},
"Engine": "aurora-mysql",
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
"PubliclyAccessible": true
},
"DependsOn": [
Expand Down Expand Up @@ -602,6 +604,7 @@
"Ref": "DatabaseSubnets56F17B9A"
},
"Engine": "aurora-mysql",
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
"PubliclyAccessible": true
},
"DependsOn": [
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,7 @@
"Ref": "DatabaseSubnets56F17B9A"
},
"Engine": "aurora-mysql",
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
"PubliclyAccessible": true
},
"DependsOn": [
Expand All @@ -547,7 +548,7 @@
"UpdateReplacePolicy": "Delete",
"DeletionPolicy": "Delete"
},
"DatabaseInstanceParameterGroup6968C5BF": {
"DatabaseInstance2WrapperInstanceParameterGroup61FBD67B": {
"Type": "AWS::RDS::DBParameterGroup",
"Properties": {
"Description": "Parameter group for aurora-mysql8.0",
Expand All @@ -563,12 +564,13 @@
},
"DBInstanceClass": "db.t3.medium",
"DBParameterGroupName": {
"Ref": "DatabaseInstanceParameterGroup6968C5BF"
"Ref": "DatabaseInstance2WrapperInstanceParameterGroup61FBD67B"
},
"DBSubnetGroupName": {
"Ref": "DatabaseSubnets56F17B9A"
},
"Engine": "aurora-mysql",
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
"PubliclyAccessible": true
},
"DependsOn": [
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 615ee2d

Please sign in to comment.