-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: remove packaging prerequisites requirements from build (#11691)
Split the prerequisites check for `pack` and `build`. Executing `build` does not execute pack, which means it does not require the tools for packaging (`mvn`, `python`, `.Net`, `java`) to be installed locally. This PR splits `check-prerequisites` into two separate scripts, `check-build-prerequisites` and `check-pack-prerequisites`. For build check: * `node` * `yarn` * `docker` (arguable, but fine) For pack check: * all build prerequisites * `mvn` * `java` * `.Net` * `python` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
Showing
4 changed files
with
102 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
#!/bin/bash | ||
set -euo pipefail | ||
|
||
scriptdir=$(cd $(dirname $0) && pwd) | ||
|
||
# Testing with this to simulate different installed apps: | ||
# docker run -it -v ~/Source/aws-cdk:/var/cdk ubuntu bash | ||
|
||
# Note: Don't use \d in regex, it doesn't work on Macs without GNU tools installed | ||
# Use [0-9] instead | ||
|
||
die() { echo "$*" 1>&2 ; exit 1; } | ||
wrong_version() { echo "Found $app version $app_v. Install $app >= $app_min" 1>&2; exit 1; } | ||
|
||
check_which() { | ||
local app=$1 | ||
local min=$2 | ||
|
||
echo -e "Checking if $app is installed... \c" | ||
|
||
w=$(which ${app}) || w="" | ||
|
||
if [ -z "$w" ] || [ "$w" == "$app not found" ] | ||
then | ||
die "Missing dependency: $app. Install $app >= $min" | ||
else | ||
echo "Ok" | ||
fi | ||
} | ||
|
||
app="" | ||
app_min="" | ||
app_v="" | ||
|
||
# [Node.js >= 10.13.0] | ||
# ⚠️ versions `13.0.0` to `13.6.0` are not supported due to compatibility issues with our dependencies. | ||
app="node" | ||
app_min="v10.13.0" | ||
check_which $app $app_min | ||
app_v=$(node --version) | ||
|
||
# Check for version 10.*.* - 29.*.* | ||
echo -e "Checking node version... \c" | ||
if [ $(echo $app_v | grep -c -E "v[12][0-9]\.[0-9]+\.[0-9]+") -eq 1 ] | ||
then | ||
# Check for version 13.0 to 13.6 | ||
if [ $(echo $app_v | grep -c -E "v13\.[0-6]\.[0-9]+") -eq 1 ] | ||
then | ||
die "node versions 13.0.0 to 13.6.0 are not supported due to compatibility issues with our dependencies." | ||
else | ||
# Check for version < 10.13 | ||
if [ $(echo $app_v | grep -c -E "v10\.([0-9]|1[0-2])\.[0-9]+") -eq 1 ] | ||
then | ||
wrong_version | ||
else | ||
echo "Ok" | ||
fi | ||
fi | ||
else | ||
echo "Not 12" | ||
wrong_version | ||
fi | ||
|
||
# [Yarn >= 1.19.1, < 1.30] | ||
app="yarn" | ||
app_min="1.19.1" | ||
check_which $app $app_min | ||
app_v=$(${app} --version) | ||
echo -e "Checking yarn version... \c" | ||
if [ $(echo $app_v | grep -c -E "1\.(19|2[0-9])\.[0-9]+") -eq 1 ] | ||
then | ||
echo "Ok" | ||
else | ||
wrong_version | ||
fi | ||
|
||
# [Docker >= 19.03] | ||
app="docker" | ||
app_min="19.03.0" | ||
check_which $app $app_min | ||
|
||
# Make sure docker is running | ||
echo -e "Checking if docker is running... \c" | ||
docker_running=$(docker ps) | ||
if [ $? -eq 0 ] | ||
then | ||
echo "Ok" | ||
else | ||
die "Docker is not running" | ||
fi | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters