chore(cli): "cdk context" is broken

aws · Oct 7, 2020 · 7722cca · 7722cca
1 parent c58127b
commit 7722cca
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 14 deletions.
diff --git a/packages/aws-cdk/lib/commands/context.ts b/packages/aws-cdk/lib/commands/context.ts
@@ -81,7 +81,7 @@ function listContext(context: any) {
 function invalidateContext(context: Context, key: string) {
   const i = parseInt(key, 10);
   if (`${i}` === key) {
-    // Twas a number and we fully parsed it.
+    // was a number and we fully parsed it.
     key = keyByNumber(context, i);
   }
 
@@ -107,7 +107,7 @@ function keyByNumber(context: any, n: number) {
  * Return enumerated keys in a definitive order
  */
 function contextKeys(context: Context): [number, string][] {
-  const keys = context.keys;
+  const keys = Object.keys(context);
   keys.sort();
   return enumerate1(keys);
 }

diff --git a/packages/aws-cdk/test/commands/context-command.test.ts b/packages/aws-cdk/test/commands/context-command.test.ts
@@ -1,30 +1,23 @@
 import { realHandler } from '../../lib/commands/context';
 import { Configuration } from '../../lib/settings';
 
-test('context reset can remove a context key', async () => {
+test('context list', async() => {
   // GIVEN
   const configuration = new Configuration();
   configuration.context.set('foo', 'bar');
-  configuration.context.set('baz', 'quux');
 
   expect(configuration.context.all).toEqual({
     foo: 'bar',
-    baz: 'quux',
   });
 
   // WHEN
   await realHandler({
     configuration,
-    args: { reset: 'foo' },
+    args: {},
   } as any);
-
-  // THEN
-  expect(configuration.context.all).toEqual({
-    baz: 'quux',
-  });
 });
 
-test('context reset can remove a context key using number', async () => {
+test('context reset can remove a context key', async () => {
   // GIVEN
   const configuration = new Configuration();
   configuration.context.set('foo', 'bar');
@@ -38,11 +31,11 @@ test('context reset can remove a context key using number', async () => {
   // WHEN
   await realHandler({
     configuration,
-    args: { reset: '1' },
+    args: { reset: 'foo' },
   } as any);
 
   // THEN
   expect(configuration.context.all).toEqual({
-    foo: 'bar',
+    baz: 'quux',
   });
 });