Skip to content

Commit

Permalink
chore: fix master build by skipping optional release notes copy (#17154)
Browse files Browse the repository at this point in the history
For releases (v1 and v2), we need to create the release notes (as part of the
build) and then copy them to the dist/ directory (as part of pack). However, for
`master` builds, we don't create the release notes because the BUMP_CANDIDATE
builds reference a non-existent release version. Assuming the presence of the
release notes in pack is causing the `master` pipeline to fail.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
njlynch authored Oct 26, 2021
1 parent 55d3c50 commit 82de2e2
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion pack.sh
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,10 @@ HERE

# copy CHANGELOG.md and RELEASE_NOTES.md to dist/ for github releases
cp ${changelog_file} ${distdir}/CHANGELOG.md
cp RELEASE_NOTES.md ${distdir}/RELEASE_NOTES.md
# Release notes are not available for bump candidate builds.
if ! ${BUMP_CANDIDATE:-false}; then
cp RELEASE_NOTES.md ${distdir}/RELEASE_NOTES.md
fi

# defensive: make sure our artifacts don't use the version marker (this means
# that "pack" will always fails when building in a dev environment)
Expand Down

0 comments on commit 82de2e2

Please sign in to comment.