Skip to content

Commit

Permalink
chore(bootstrap): enable s3 versioning (#14987)
Browse files Browse the repository at this point in the history
It would be great to enable S3 versioning on CDK's staging bucket.
This would be a safer option and consistent with UpdateReplacePolicy and DeletionPolicy being Retain.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
umireon authored Jun 14, 2021
1 parent 8816e95 commit 92cadef
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/aws-cdk/lib/api/bootstrap/bootstrap-template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,8 @@ Resources:
IgnorePublicAcls: true
RestrictPublicBuckets: true
- Ref: AWS::NoValue
VersioningConfiguration:
Status: Enabled
UpdateReplacePolicy: Retain
DeletionPolicy: Retain
StagingBucketPolicy:
Expand Down

0 comments on commit 92cadef

Please sign in to comment.