fix(sqs): redrivePermission is set to byQueue no matter what valu…

…e is specified
aws · Feb 18, 2024 · 9ea12d1 · 9ea12d1
1 parent b4daf84
commit 9ea12d1
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 3 deletions.
diff --git a/...test/aws-sqs/test/integ.sqs-source-queue-permission.js.snapshot/aws-cdk-sqs.template.json b/...test/aws-sqs/test/integ.sqs-source-queue-permission.js.snapshot/aws-cdk-sqs.template.json
@@ -2,11 +2,21 @@
  "Resources": {
   "SourceQueue1F4BBA4BB": {
    "Type": "AWS::SQS::Queue",
+   "Properties": {
+    "RedriveAllowPolicy": {
+      "redrivePermission": "allowAll"
+    }
+   },
    "UpdateReplacePolicy": "Delete",
    "DeletionPolicy": "Delete"
   },
   "SourceQueue22481CB5A": {
    "Type": "AWS::SQS::Queue",
+   "Properties": {
+    "RedriveAllowPolicy": {
+      "redrivePermission": "denyAll"
+    }
+   },
    "UpdateReplacePolicy": "Delete",
    "DeletionPolicy": "Delete"
   },

diff --git a/...s/@aws-cdk-testing/framework-integ/test/aws-sqs/test/integ.sqs-source-queue-permission.ts b/...s/@aws-cdk-testing/framework-integ/test/aws-sqs/test/integ.sqs-source-queue-permission.ts
@@ -7,8 +7,16 @@ const app = new App();
 
 const stack = new Stack(app, 'aws-cdk-sqs');
 
-const sourceQueue1 = new Queue(stack, 'SourceQueue1');
-const sourceQueue2 = new Queue(stack, 'SourceQueue2');
+const sourceQueue1 = new Queue(stack, 'SourceQueue1', {
+  redriveAllowPolicy: {
+    redrivePermission: RedrivePermission.ALLOW_ALL,
+  },
+});
+const sourceQueue2 = new Queue(stack, 'SourceQueue2', {
+  redriveAllowPolicy: {
+    redrivePermission: RedrivePermission.DENY_ALL,
+  },
+});
 
 new Queue(stack, 'DeadLetterQueue', {
   redriveAllowPolicy: {

diff --git a/packages/aws-cdk-lib/aws-sqs/lib/queue.ts b/packages/aws-cdk-lib/aws-sqs/lib/queue.ts
@@ -411,7 +411,7 @@ export class Queue extends QueueBase {
       redrivePermission: props.redriveAllowPolicy.redrivePermission
       // When `sourceQueues` is provided in `redriveAllowPolicy`, `redrivePermission` defaults to allow specified queues (`BY_QUEUE`);
       // otherwise, it defaults to allow all queues (`ALLOW_ALL`).
-        ?? props.redriveAllowPolicy.sourceQueues ? RedrivePermission.BY_QUEUE : RedrivePermission.ALLOW_ALL,
+        ?? (props.redriveAllowPolicy.sourceQueues ? RedrivePermission.BY_QUEUE : RedrivePermission.ALLOW_ALL),
       sourceQueueArns: props.redriveAllowPolicy.sourceQueues?.map(q => q.queueArn),
     } : undefined;
 

diff --git a/packages/aws-cdk-lib/aws-sqs/test/sqs.test.ts b/packages/aws-cdk-lib/aws-sqs/test/sqs.test.ts
@@ -753,6 +753,33 @@ describe('redriveAllowPolicy', () => {
     });
   });
 
+  test.each([
+    [sqs.RedrivePermission.ALLOW_ALL, 'allowAll'],
+    [sqs.RedrivePermission.DENY_ALL, 'denyAll'],
+  ])('redrive permission can be set to %s', (permission, expected) => {
+    const stack = new Stack();
+    new sqs.Queue(stack, 'Queue', {
+      redriveAllowPolicy: {
+        redrivePermission: permission,
+      },
+    });
+
+    Template.fromStack(stack).templateMatches({
+      'Resources': {
+        'Queue4A7E3555': {
+          'Type': 'AWS::SQS::Queue',
+          'Properties': {
+            'RedriveAllowPolicy': {
+              'redrivePermission': expected,
+            },
+          },
+          'UpdateReplacePolicy': 'Delete',
+          'DeletionPolicy': 'Delete',
+        },
+      },
+    });
+  });
+
   test('explicit specification of dead letter source queues', () => {
     const stack = new Stack();
     const sourceQueue1 = new sqs.Queue(stack, 'SourceQueue1');