fix(rds): Make parameters required

aws · Mar 24, 2019 · ad3d753 · ad3d753
1 parent 46b7558
commit ad3d753
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/@aws-cdk/aws-rds/lib/instance-parameter-group.ts b/packages/@aws-cdk/aws-rds/lib/instance-parameter-group.ts
@@ -41,7 +41,7 @@ export interface InstanceParameterGroupProps {
   /**
    * The parameters in this parameter group
    */
-  parameters?: Parameters;
+  parameters: Parameters;
 }
 
 /**

diff --git a/packages/@aws-cdk/aws-rds/test/test.cluster.ts b/packages/@aws-cdk/aws-rds/test/test.cluster.ts
@@ -169,6 +169,7 @@ export = {
     const instanceParameterGroup = new InstanceParameterGroup(stack, 'Params', {
       family: 'mysql',
       description: 'bye',
+      parameters: {},
     });
     instanceParameterGroup.setParameter('param1', 'value1');
     instanceParameterGroup.setParameter('param2', 'value2');
@@ -220,7 +221,8 @@ export = {
     const stack = testStack();
     const group = new InstanceParameterGroup(stack, 'Params', {
       family: 'hello',
-      description: 'desc'
+      description: 'desc',
+      parameters: {},
     });
 
     // WHEN
-Original file line number
+Diff line change
@@ Expand Up / @@ -41,7 +41,7 @@ export interface InstanceParameterGroupProps { @@
       /**
        * The parameters in this parameter group
        */
-      parameters?: Parameters;
+      parameters: Parameters;
     }
     /**
@@ Expand Down @@