Skip to content

Commit

Permalink
feat: grantRead on a Secret also grants DescribeSecret
Browse files Browse the repository at this point in the history
  • Loading branch information
comcalvi committed Jun 5, 2020
1 parent 62ccf9a commit c431ee1
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@
"PolicyDocument": {
"Statement": [
{
"Action": "secretsmanager:GetSecretValue",
"Action": [
"secretsmanager:GetSecretValue",
"secretsmanager:DescribeSecret"
],
"Effect": "Allow",
"Resource": {
"Ref": "SecretA720EF05"
Expand Down Expand Up @@ -121,4 +124,4 @@
}
}
}
}
}
10 changes: 8 additions & 2 deletions packages/@aws-cdk/aws-secretsmanager/test/test.secret.ts
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,10 @@ export = {
PolicyDocument: {
Version: '2012-10-17',
Statement: [{
Action: 'secretsmanager:GetSecretValue',
Action: [
'secretsmanager:GetSecretValue',
'secretsmanager:DescribeSecret',
],
Effect: 'Allow',
Resource: { Ref: 'SecretA720EF05' },
}],
Expand Down Expand Up @@ -252,7 +255,10 @@ export = {
PolicyDocument: {
Version: '2012-10-17',
Statement: [{
Action: 'secretsmanager:GetSecretValue',
Action: [
'secretsmanager:GetSecretValue',
'secretsmanager:DescribeSecret',
],
Effect: 'Allow',
Resource: { Ref: 'SecretA720EF05' },
Condition: {
Expand Down

0 comments on commit c431ee1

Please sign in to comment.