only add dependency if topic is of type Topic

aws · Nov 8, 2021 · c69977b · c69977b
1 parent cbdff3d
commit c69977b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/@aws-cdk/aws-sns-subscriptions/lib/lambda.ts b/packages/@aws-cdk/aws-sns-subscriptions/lib/lambda.ts
@@ -38,7 +38,7 @@ export class LambdaSubscription implements sns.ITopicSubscription {
 
     // if the topic and function are created in different stacks
     // then we need to make sure the topic is created first
-    if (topic.stack !== this.fn.stack) {
+    if (topic instanceof sns.Topic && topic.stack !== this.fn.stack) {
       this.fn.stack.addDependency(topic.stack);
     }
 

diff --git a/packages/@aws-cdk/aws-sns-subscriptions/lib/sqs.ts b/packages/@aws-cdk/aws-sns-subscriptions/lib/sqs.ts
@@ -63,7 +63,7 @@ export class SqsSubscription implements sns.ITopicSubscription {
 
     // if the topic and queue are created in different stacks
     // then we need to make sure the topic is created first
-    if (topic.stack !== this.queue.stack) {
+    if (topic instanceof sns.Topic && topic.stack !== this.queue.stack) {
       this.queue.stack.addDependency(topic.stack);
     }