Rename to kafkaSecret and change type

aws · Jan 18, 2021 · c90691f · c90691f
1 parent e7c1eb6
commit c90691f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts b/packages/@aws-cdk/aws-lambda-event-sources/lib/kafka.ts
@@ -31,7 +31,7 @@ export class ManagedKafkaEventSource extends StreamEventSource {
       this.enrichMappingOptions({
         eventSourceArn: this.clusterArn,
         startingPosition: this.props.startingPosition,
-        kafkaSecretArn: this.secret.secretArn,
+        kafkaSecret: this.secret,
         kafkaTopic: this.topic,
       }),
     );
@@ -75,7 +75,7 @@ export class SelfManagedKafkaEventSource extends StreamEventSource {
         kafkaBootstrapServers: this.bootstrapServers,
         kafkaTopic: this.topic,
         startingPosition: this.props.startingPosition,
-        kafkaSecretArn: this.secret.secretArn,
+        kafkaSecret: this.secret,
       }),
     );
     this.secret.grantRead(target);

diff --git a/packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts b/packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts
@@ -1,3 +1,4 @@
+import { ISecret } from '@aws-cdk/aws-secretsmanager';
 import * as cdk from '@aws-cdk/core';
 import { Construct } from 'constructs';
 import { IEventSourceDlq } from './dlq';
@@ -109,7 +110,7 @@ export interface EventSourceMappingOptions {
    *
    * @default - no configuration
    */
-  readonly kafkaSecretArn?: string
+  readonly kafkaSecret?: ISecret
 
   /**
    * A list of Kafka bootstrap servers to connect to your self managed Kafka cluster
@@ -212,7 +213,7 @@ export class EventSourceMapping extends cdk.Resource implements IEventSourceMapp
       maximumRetryAttempts: props.retryAttempts,
       parallelizationFactor: props.parallelizationFactor,
       topics: props.kafkaTopic !== undefined ? [props.kafkaTopic] : undefined,
-      sourceAccessConfigurations: props.kafkaSecretArn !== undefined ? [{ type: 'BASIC_AUTH', uri: props.kafkaSecretArn }] : undefined,
+      sourceAccessConfigurations: props.kafkaSecret !== undefined ? [{ type: 'BASIC_AUTH', uri: props.kafkaSecret.secretArn }] : undefined,
       // eslint-disable-next-line max-len
       selfManagedEventSource: props.kafkaBootstrapServers !== undefined ? { endpoints: { kafkaBootstrapServers: props.kafkaBootstrapServers } } : undefined,
     });

diff --git a/packages/@aws-cdk/aws-lambda/package.json b/packages/@aws-cdk/aws-lambda/package.json
@@ -101,6 +101,7 @@
     "@aws-cdk/aws-logs": "0.0.0",
     "@aws-cdk/aws-s3": "0.0.0",
     "@aws-cdk/aws-s3-assets": "0.0.0",
+    "@aws-cdk/aws-secretsmanager": "0.0.0",
     "@aws-cdk/aws-sqs": "0.0.0",
     "@aws-cdk/core": "0.0.0",
     "@aws-cdk/cx-api": "0.0.0",
@@ -121,6 +122,7 @@
     "@aws-cdk/aws-logs": "0.0.0",
     "@aws-cdk/aws-s3": "0.0.0",
     "@aws-cdk/aws-s3-assets": "0.0.0",
+    "@aws-cdk/aws-secretsmanager": "0.0.0",
     "@aws-cdk/aws-sqs": "0.0.0",
     "@aws-cdk/core": "0.0.0",
     "@aws-cdk/cx-api": "0.0.0",