Skip to content

Commit

Permalink
build: skip compatibility check for Gitpod (#9315)
Browse files Browse the repository at this point in the history
There is no point in doing the compatibility check when spinning up a new Gitpod workspace,
so add an option to build.sh to skip it,
and use it for the Gitpod build.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
skinny85 authored Jul 29, 2020
1 parent eec849b commit d8f3ce8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .gitpod.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
image: jsii/superchain
tasks:
- init: yarn build --skip-test --no-bail --skip-prereqs
- init: yarn build --skip-test --no-bail --skip-prereqs --skip-compat

vscode:
extensions:
Expand Down
8 changes: 7 additions & 1 deletion build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ set -euo pipefail
bail="--bail"
runtarget="build+test"
check_prereqs="true"
check_compat="true"
while [[ "${1:-}" != "" ]]; do
case $1 in
-h|--help)
Expand All @@ -22,6 +23,9 @@ while [[ "${1:-}" != "" ]]; do
--skip-prereqs)
check_prereqs="false"
;;
--skip-compat)
check_compat="false"
;;
*)
echo "Unrecognized parameter: $1"
exit 1
Expand Down Expand Up @@ -70,6 +74,8 @@ echo "==========================================================================
echo "building..."
time lerna run $bail --stream $runtarget || fail

/bin/bash scripts/check-api-compatibility.sh
if [ "$check_compat" == "true" ]; then
/bin/bash scripts/check-api-compatibility.sh
fi

touch $BUILD_INDICATOR

0 comments on commit d8f3ce8

Please sign in to comment.