Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(ecs): cannot disable container insights of an ECS cluster (#9151)
fixes #9149 The clusterSettings should be explicitly defined even when container insights is disabled, because CFn doesn't allow to remove the existing settings (as described in the issue.) By this change, users who sets `containerInsights` prop `false` will see a diff like below, but it won't be a problem because by default container insights is disabled hence no actual change to existing resources: ``` Resources [~] AWS::ECS::Cluster cluster cluster611F8AFF └─ [+] ClusterSettings └─ [{"Name":"containerInsights","Value":"disabled"}] ``` To prevent the existing tests from failing, the clusterSettings is only defined when `containerInsight` prop is explicitly defined(i.e. `true` or `false`, not `undefined`.) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information