fix(aws-codebuild): correctly set S3 path when using it as artifact. (#…

…1072)
aws · Nov 5, 2018 · f32cba9 · f32cba9
1 parent d7ef2a5
commit f32cba9
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/packages/@aws-cdk/aws-codebuild/lib/artifacts.ts b/packages/@aws-cdk/aws-codebuild/lib/artifacts.ts
@@ -72,7 +72,7 @@ export class S3BucketBuildArtifacts extends BuildArtifacts {
  return {
  type: 'S3',
  location: this.props.bucket.bucketName,
- path: this.props.bucket.path,
+ path: this.props.path,
  namespaceType: this.parseNamespaceType(this.props.includeBuildID),
  name: this.props.name,
  packaging: this.parsePackaging(this.props.packageZip),

diff --git a/packages/@aws-cdk/aws-codebuild/test/test.codebuild.ts b/packages/@aws-cdk/aws-codebuild/test/test.codebuild.ts
@@ -466,6 +466,28 @@ export = {
  }
  },
 
+ 'using path in S3 artifacts sets it correctly'(test: Test) {
+ const stack = new cdk.Stack();
+ const bucket = new s3.Bucket(stack, 'Bucket');
+ new codebuild.Project(stack, 'Project', {
+ artifacts: new codebuild.S3BucketBuildArtifacts({
+ path: 'some/path',
+ name: 'some_name',
+ bucket,
+ }),
+ });
+
+ expect(stack).to(haveResource('AWS::CodeBuild::Project', {
+ "Artifacts": {
+ "Path": "some/path",
+ "Name": "some_name",
+ "Type": "S3",
+ },
+ }));
+
+ test.done();
+ },
+
  'artifacts': {
  'CodePipeline': {
  'both source and artifacs are set to CodePipeline'(test: Test) {