Skip to content

Commit

Permalink
fix(custom-resources): corrected the AWS SDK v2 to v3 mapping for mem…
Browse files Browse the repository at this point in the history
…orydb service.
  • Loading branch information
ashishdhingra committed Oct 24, 2024
1 parent dc3ac4e commit fe1f085
Show file tree
Hide file tree
Showing 58 changed files with 2,682 additions and 1,174 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@types/node": "18.11.19",
"@types/prettier": "2.6.0",
"@yarnpkg/lockfile": "^1.1.0",
"aws-sdk-js-codemod": "^0.28.2",
"aws-sdk-js-codemod": "^2.3.3",
"cdk-generate-synthetic-examples": "^0.2.14",
"conventional-changelog-cli": "^2.2.2",
"fs-extra": "^9.1.0",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

This file was deleted.

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,11 @@
{
"Ref": "AthenaResultBucketDF85B968"
},
"\"},\"EngineVersion\":{\"SelectedEngineVersion\":\"PySpark engine version 3\"}}}}"
"\"},\"EngineVersion\":{\"SelectedEngineVersion\":\"PySpark engine version 3\"}}},\"logApiResponseData\":true}"
]
]
},
"Delete": "{\"service\":\"Athena\",\"action\":\"deleteWorkGroup\",\"parameters\":{\"WorkGroup\":\"TestWG\"}}",
"Delete": "{\"service\":\"Athena\",\"action\":\"deleteWorkGroup\",\"parameters\":{\"WorkGroup\":\"TestWG\"},\"logApiResponseData\":true}",
"InstallLatestAwsSdk": true
},
"UpdateReplacePolicy": "Delete",
Expand All @@ -161,7 +161,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "9e8936ba1db43e0919ba2fc8265d50686eeaca82830c471ff8b7b0672c5970ec.zip"
"S3Key": "2359c08010c7366fb09aaafebc3e74155a1ccccb96b6469afc6797cebb51e513.zip"
},
"Handler": "index.handler",
"MemorySize": 512,
Expand Down Expand Up @@ -195,9 +195,9 @@
"Arn"
]
},
"Create": "{\"service\":\"Athena\",\"action\":\"createNotebook\",\"physicalResourceId\":{\"responsePath\":\"NotebookId\"},\"parameters\":{\"WorkGroup\":\"TestWG\",\"Name\":\"MyNotebook1\"}}",
"Update": "{\"service\":\"Athena\",\"action\":\"updateNotebookMetadata\",\"parameters\":{\"Name\":\"MyNotebook1\",\"NotebookId\":\"PHYSICAL:RESOURCEID:\"}}",
"Delete": "{\"service\":\"Athena\",\"action\":\"deleteNotebook\",\"parameters\":{\"NotebookId\":\"PHYSICAL:RESOURCEID:\"}}",
"Create": "{\"service\":\"Athena\",\"action\":\"createNotebook\",\"physicalResourceId\":{\"responsePath\":\"NotebookId\"},\"parameters\":{\"WorkGroup\":\"TestWG\",\"Name\":\"MyNotebook1\"},\"logApiResponseData\":true}",
"Update": "{\"service\":\"Athena\",\"action\":\"updateNotebookMetadata\",\"parameters\":{\"Name\":\"MyNotebook1\",\"NotebookId\":\"PHYSICAL:RESOURCEID:\"},\"logApiResponseData\":true}",
"Delete": "{\"service\":\"Athena\",\"action\":\"deleteNotebook\",\"parameters\":{\"NotebookId\":\"PHYSICAL:RESOURCEID:\"},\"logApiResponseData\":true}",
"InstallLatestAwsSdk": true
},
"DependsOn": [
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -40,19 +40,19 @@
{
"Ref": "myTableA48C5C70"
},
"\"},\"physicalResourceId\":{\"id\":\"myCRphysicalResourceID\"}}"
"\"},\"physicalResourceId\":{\"id\":\"myCRphysicalResourceID\"},\"logApiResponseData\":true}"
]
]
},
"Update": {
"Fn::Join": [
"",
[
"{\"service\":\"DynamoDB\",\"action\":\"PutItem\",\"parameters\":{\"service\":\"DynamoDB\",\"action\":\"PutItem\",\"parameters\":{\"Item\":{\"id\":{\"S\":\"test-value\"}},\"TableName\":\"",
"{\"service\":\"DynamoDB\",\"action\":\"PutItem\",\"parameters\":{\"Item\":{\"id\":{\"S\":\"test-value\"}},\"TableName\":\"",
{
"Ref": "myTableA48C5C70"
},
"\"},\"physicalResourceId\":{\"id\":\"myCRphysicalResourceID\"}}}"
"\"},\"logApiResponseData\":true}"
]
]
},
Expand Down Expand Up @@ -123,7 +123,7 @@
"S3Bucket": {
"Fn::Sub": "cdk-hnb659fds-assets-${AWS::AccountId}-${AWS::Region}"
},
"S3Key": "9e8936ba1db43e0919ba2fc8265d50686eeaca82830c471ff8b7b0672c5970ec.zip"
"S3Key": "2359c08010c7366fb09aaafebc3e74155a1ccccb96b6469afc6797cebb51e513.zip"
},
"Handler": "index.handler",
"MemorySize": 1024,
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,10 @@ export class AWSCustomResourceDynamoDb extends cdk.Stack {
service: 'DynamoDB',
action: 'PutItem',
parameters: {
service: 'DynamoDB',
action: 'PutItem',
parameters: {
Item: {
id: { S: 'test-value' },
},
TableName: myTable.tableName,
Item: {
id: { S: 'test-value' },
},
physicalResourceId: cr.PhysicalResourceId.of('myCRphysicalResourceID'),
TableName: myTable.tableName,
},
},
});
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Loading

0 comments on commit fe1f085

Please sign in to comment.