AWS CDK: Deploying cross env stack error

[iiljazi]

Hello, I'm creating several cross-env buckets via the aws cdk. Everything is fine when I use my own bucket names, but if I try to use cdk.PhysicalName.GENERATE_IF_NEEDED, it throws an exception that the account is unresolved or missing. When I try to print out the account number I get the sub: ${Token[AWS.AccountId.3]}. I'm not sure why the account number wouldn't resolve if the only thing I do differently is set my own bucket names vs. allowing cloudformation to pick. Thanks in advance!

const bucket = new s3.Bucket(this, "Bucket", {
        bucketName: cdk.PhysicalName.GENERATE_IF_NEEDED,
        encryption: s3.BucketEncryption.S3_MANAGED, 
        blockPublicAccess: s3.BlockPublicAccess.BLOCK_ALL,
        removalPolicy: cdk.RemovalPolicy.DESTROY,
        autoDeleteObjects: true
      });

Error: Resolution error: Resolution error: Resolution error: Resolution error: Cannot generate a physical name for BucketStack1/Bucket, because the account is un-resolved or missing.
Object creation stack:
  at stack traces disabled.
Object creation stack:
  at stack traces disabled..
    at generatePhysicalName (/Users/iljazi/Projects/React/CerberusCloud/node_modules/aws-cdk-lib/core/lib/private/physical-name-generator.js:1:1112)
    at Bucket.generatePhysicalName (/Users/iljazi/Projects/React/CerberusCloud/node_modules/aws-cdk-lib/core/lib/resource.js:1:3568)
    at Bucket._enableCrossEnvironment (/Users/iljazi/Projects/React/CerberusCloud/node_modules/aws-cdk-lib/core/lib/resource.js:1:2967)
    at Object.produce (/Users/iljazi/Projects/React/CerberusCloud/node_modules/aws-cdk-lib/core/lib/resource.js:1:4422)
    at Reference.resolve (/Users/iljazi/Projects/React/CerberusCloud/node_modules/aws-cdk-lib/core/lib/resource.js:1:4877)
    at RememberingTokenResolver.resolveToken (/Users/iljazi/Projects/React/CerberusCloud/node_modules/aws-cdk-lib/core/lib/resolvable.js:1:1401)
    at RememberingTokenResolver.resolveToken (/Users/iljazi/Projects/React/CerberusCloud/node_modules/aws-cdk-lib/core/lib/private/resolve.js:1:4134)
    at resolve (/Users/iljazi/Projects/React/CerberusCloud/node_modules/aws-cdk-lib/core/lib/private/resolve.js:1:2711)
    at Object.resolve [as mapToken] (/Users/iljazi/Projects/React/CerberusCloud/node_modules/aws-cdk-lib/core/lib/private/resolve.js:1:1079)
    at TokenizedStringFragments.mapTokens (/Users/iljazi/Projects/React/CerberusCloud/node_modules/aws-cdk-lib/core/lib/string-fragments.js:1:1475)

[Frank3354]

I was able to solve this problem by adding my AWS Account ID as an environment variable, and then adding it as a stack prop.

const app = new App();

const bucketStack = new BucketStack(app, "BucketStack", {
  env: {
    account: process.env.ACCOUNT_ID,
    region: "us-east-2"
  }
})

[khushail]

@iiljazi , for deplyment across environment, GENERATE_IF_NEEDED inherently invokes this method and checks if the account details are provided-

aws-cdk/packages/aws-cdk-lib/core/lib/private/physical-name-generator.ts

Line 10 in 2122461

export function generatePhysicalName(resource: IResource): string {

export function generatePhysicalName(resource: IResource): string {
  const stack = Stack.of(resource);
  const stackPart = new PrefixNamePart(stack.stackName, 25);
  const idPart = new SuffixNamePart(Names.nodeUniqueId(resource.node), 24);

  const region: string = stack.region;
  if (Token.isUnresolved(region) || !region) {
    throw new Error(`Cannot generate a physical name for ${Node.of(resource).path}, because the region is un-resolved or missing`);
  }

  const account: string = stack.account;
  if (Token.isUnresolved(account) || !account) {
    throw new Error(`Cannot generate a physical name for ${Node.of(resource).path}, because the account is un-resolved or missing`);
  }

so as @Frank3354 mentioned, solution to avoid above error would be to mention environment details.