Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Record any changes in stack termination protection flag as an event in the stack itself #10163

Closed
2 tasks
idclipr opened this issue Sep 3, 2020 · 3 comments
Assignees
Labels
guidance Question that needs advice or information. package/tools Related to AWS CDK Tools or CLI

Comments

@idclipr
Copy link

idclipr commented Sep 3, 2020

Record any changes in stack termination protection flag as an event in the stack itself.

Use Case

Currently cdk bootstrap command enables and disables the termination protection flag based on the presence or absence of the --termination-protection option in the command line. Users can also modify that flag in AWS Console at any time.

However, this change does not have any audit record and it's impossible to understand when/why/by whom the flag setting have changed.

Proposed Solution

Add a "stack event" for the termination protection flag change so that it shows up in "Events" in AWS Console.

Other

This is somewhat a follow-up to #9002 and subsequent #10091, so it can be considered a bug of how the flag was implemented to begin with (and not a new "feature").

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request but could be viewed as a bug of the initial implementation

@idclipr idclipr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 3, 2020
@idclipr idclipr changed the title [module] [core?] Record any changes in stack termination protection flag as an event in the stack itself Sep 3, 2020
@SomayaB SomayaB changed the title [core?] Record any changes in stack termination protection flag as an event in the stack itself [CLI] Record any changes in stack termination protection flag as an event in the stack itself Sep 3, 2020
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Sep 3, 2020
@SomayaB SomayaB assigned rix0rrr and unassigned shivlaks Sep 3, 2020
@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 7, 2020

We don't have the power to make those changes in the AWS Console. But CloudTrail has a full record of all API calls done to any service so it will show up there.

@rix0rrr rix0rrr added guidance Question that needs advice or information. and removed feature-request A feature should be added or improved. labels Sep 7, 2020
@rix0rrr rix0rrr assigned NGL321 and SomayaB and unassigned rix0rrr Sep 7, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Sep 8, 2020
@SomayaB
Copy link
Contributor

SomayaB commented Oct 19, 2020

Closing this issue since there doesn't seem to be anything actionable for the cdk. Feel free to reopen.

@SomayaB SomayaB closed this as completed Oct 19, 2020
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

5 participants