feat(cli): bootstrap stacks are protected from termination by default #9002
+68
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be turned off using a flag on the CLI.
NetaNir
reviewed
Jul 11, 2020
| expect(protectedTermination).toBeTruthy(); | ||
| }); | ||
|
|
||
| test('termination protected is turned off when unset', async () => { |
There was a problem hiding this comment.
'termination protected is turned off when set to false'?
NetaNir
approved these changes
Jul 11, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
shivlaks
reviewed
Jul 13, 2020
Comment on lines
+253
to
+254
| By default, bootstrap stack will be protected from stack termination. This can be disabled using | ||
| `--termination-protection` argument. |
There was a problem hiding this comment.
I believe yargs also supports -no--termination-protection as well (convention for boolean flags)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in line with the best practice for stacks in production, so as
to prevent accidental termination.
This can be turned off using a flag on the CLI.
Besides unit tests here, this has been verified by manual testing.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license