Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-events-targets] Specify platformVersion for EcsTask #10186

Closed
1 of 2 tasks
kuwa0224 opened this issue Sep 4, 2020 · 0 comments · Fixed by #10223
Closed
1 of 2 tasks

[aws-events-targets] Specify platformVersion for EcsTask #10186

kuwa0224 opened this issue Sep 4, 2020 · 0 comments · Fixed by #10223
Assignees
@shivlaks
Labels
@aws-cdk/aws-events-targets effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@kuwa0224
Copy link
Contributor

kuwa0224 commented Sep 4, 2020 •
edited
Loading

EcsTask always uses fargate platform version as LATEST implicitly.
CDK users maybe want to specify platform version explicitly.

Use Case

The actual version pointed to by LATEST will change in the future.
CDK users may not notice those changes.
In that case, set it to a fixed value for safety.

Proposed Solution

Add platformVersion property to EcsTaskProps, and when it exists, use it in ecsParameters.

    /**
     * The platform version on which to run your fargate task.
     */
     readonly platformVersion?: ecs.FargatePlatformVersion;

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@kuwa0224 kuwa0224 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 4, 2020
@kuwa0224 kuwa0224 mentioned this issue Sep 7, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 8, 2020
kuwa0224 added a commit to kuwa0224/aws-cdk that referenced this issue Sep 11, 2020
@kuwa0224
feat(events-targets): supports to specify fargate platform version
e03267d 
Fixes aws#10186

EcsTask always uses fargate platform version as LATEST implicitly.
CDK users maybe want to specify platform version explicitly.
kuwa0224 added a commit to kuwa0224/aws-cdk that referenced this issue Sep 11, 2020
@kuwa0224
test(events-targets): support fargate platform version (aws#10186)
d71cab4 
Add the following test.

Create a Rule using ECSTask with platformVersion specified in props.
Checks whether the specified value is used in the created Rule.
@shivlaks shivlaks added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Sep 15, 2020
@mergify mergify bot closed this as completed in #10223 Sep 16, 2020
mergify bot pushed a commit that referenced this issue Sep 16, 2020
@kuwa0224
feat(events-targets): supports to specify fargate platform version (#…
3dcd01e 
…10223)

Fixes #10186 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivlaks shivlaks

Labels
@aws-cdk/aws-events-targets effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(events-targets): supports to specify fargate platform version kuwa0224/aws-cdk
3 participants
@kuwa0224 @SomayaB @shivlaks