Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-eks] bottlerocket version to follow the cluster version #10188

Closed
1 of 2 tasks
pahud opened this issue Sep 4, 2020 · 0 comments · Fixed by #10189
Closed
1 of 2 tasks

[aws-eks] bottlerocket version to follow the cluster version #10188

pahud opened this issue Sep 4, 2020 · 0 comments · Fixed by #10189
Assignees
@iliapolo
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@pahud
Copy link
Contributor

pahud commented Sep 4, 2020 •
edited
Loading

https://github.com/bottlerocket-os/bottlerocket/blob/develop/QUICKSTART-EKS.md

bottlerocket for eks now supports aws-k8s-1.16 and aws-k8s-1.17 variants and the BottleRocketImage() should select the variant based on the cluster k8s version for consistency. Previously, only 1.15 is available.

aws-cdk/packages/@aws-cdk/aws-eks/lib/cluster.ts

Lines 1698 to 1704 in ec15485

public constructor() {
// only 1.15 is currently available
this.kubernetesVersion = '1.15';
// set the SSM parameter name
this.amiParameterName = `/aws/service/bottlerocket/aws-k8s-${this.kubernetesVersion}/x86_64/latest/image_id`;
}

Use Case

Proposed Solution

follow the cluster k8s version

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@pahud pahud added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 4, 2020
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Sep 4, 2020
@pahud pahud mentioned this issue Sep 4, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 4, 2020
@iliapolo iliapolo added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2020
@mergify mergify bot closed this as completed in #10189 Sep 14, 2020
mergify bot pushed a commit that referenced this issue Sep 14, 2020
@pahud
feat(eks): bottlerocket versoin follows the cluster k8s versoin (#10189)
19638a6 
This PR will implicitly select correct bottlerocket variant in consist with the  cluster k8s version. For example, if the cluster k8s version is `1.17`, previously only bottlerocket `aws-k8s-1.15` variant is available. Now the variant will be `aws-k8s-1.17`

BREAKING CHANGE: Clusters previously running k8s version other than `1.15` and bottlerocket AMI(`aws-k8s-1.15` variant) will trigger AMI and node replacement.

Closes: #10188 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@iliapolo iliapolo removed the in-progress This issue is being actively worked on. label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iliapolo iliapolo

Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eks): bottlerocket versoin follows the cluster k8s versoin
3 participants
@pahud @iliapolo @SomayaB