Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-batch): computeResources tags are not configured properly #10209

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

rsmogura
Copy link
Contributor

@rsmogura rsmogura commented Sep 7, 2020

Use key-value map of tags for ComputeResources.computeResourcesTags.

Previously used type Tag disallowed adding multiple tags.

Fixes #7350

BREAKING CHANGE: Changed type of ComputeResources.computeResourcesTags from Tag to map


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Use key-value map of tags for `ComputeResources.computeResourcesTags`.

Previously used type `Tag` disallowed adding multiple tags.

**Fixes aws#7350**

BREAKING CHANGE: Changed type of `ComputeResources.computeResourcesTags`
from `Tag` to map (details in fixed issue).
@iliapolo iliapolo changed the title fix(aws-batch): computeResourcesTags use tag map fix(aws-batch): compute resource tags are not configured properly Sep 8, 2020
@iliapolo iliapolo changed the title fix(aws-batch): compute resource tags are not configured properly fix(aws-batch): computeResources tags are not configured properly Sep 8, 2020
Copy link
Contributor

@iliapolo iliapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rsmogura Sweet, thanks! :)

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cbdcd0e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 40222ef into aws:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid type for parameter computeResources.tags.props
3 participants