Invalid type for parameter computeResources.tags.props

[cfriedline]

When adding a tag to Batch Compute Resources, the synth succeeds, but does not deploy. The messages written indicate the that parameter validation may be incorrect:

Reference: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-batch-computeenvironment-computeresources.html

Reproduction Steps

Tag without properties

cr = batch.ComputeResources(
            vpc=vpc,
            ec2_key_pair=key_pair,
            compute_resources_tags=Tag("Name", tags[self.lims.env]["Name"]),
            ...
        )

Results in:

Invalid type for parameter computeResources.tags.props, value: {}, type: <type 'dict'>, valid types: <type 'basestring'>

Synth:

Tags:
          key: Name
          props: {}
          defaultPriority: 100
          value: debug-lims-assay-processor

Tag with properties

cr = batch.ComputeResources(
            vpc=vpc,
            ec2_key_pair=key_pair[self.lims.env],
            compute_resources_tags=Tag(
                "Name", tags[self.lims.env]["Name"], apply_to_launched_instances=True
            ),
...

Results in:

Invalid type for parameter computeResources.tags.props, value: {u'applyToLaunchedInstances': u'true'}, type: <type 'dict'>, valid types: <type 'basestring'>

Synth:

Tags:
          key: Name
          props:
            applyToLaunchedInstances: true
          defaultPriority: 100
          value: debug-lims-assay-processor

Error Log

See above...

Environment

• CLI Version : 1.32.2
• Framework Version: 1.32.2
• OS : MacOS
• Language : Python

---

This is 🐛 Bug Report

[cfriedline]

Hi there. Thanks for kicking this ticket around in priority. Wondering also if multiple tags could be enabled, as well. The type hint indicates that only a single tag would be permitted.

compute_resources_tags: Optional[Tag] = None,

when

compute_resources_tags: Optional[List[Tag]] = None,

might be more what most people would need.

[iliapolo]

Hi @cfriedline. Yes, baring any unforeseen circumstances, it will be possible to provide multiple tags.

[rsmogura]

Hi,

I'm affected by this issue in TypeScript, too. Workaround for me is tags as unknown as cdk.Tag.

I can try to open patch for this, fix should be easy. However I there are few ways to implement this:

1. Change the type of computeResourcesTags to plain key-value (string, string) map.
2. Use Tag
3. Use Tags (which would require changing this class to add option of constructing it without CDK construct as backend)

[iliapolo]

@rsmogura If you could provide a fix that would be great.

Let go with approach number 1?

[rsmogura]

Sounds good