fix(diff): deepEqual may miss difference other than DependsOn
#10394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will resolve conflicts. |
Reproduce aws#10322 The important point of this case is the properties order of `BucketResource`. ``` BucketResource: { Type: 'AWS::S3::Bucket', DependsOn: ['SomeResource'], BucketName: bucketName, } ``` can reproduce, but ``` BucketResource: { Type: 'AWS::S3::Bucket', BucketName: bucketName, DependsOn: ['SomeResource'], } ``` cannot reproduce. Because, `deepEqual` in `util.ts` is dependent on `Object.keys` order. This issue occurs when the property of not-changed `DependsOn` is evaluated before the property that has changed.
Fix the issue (10322) for `deepEqual`. The cause of this issue was that checking the diffs in the `DependsOn` property returned a result of` dependsOnEqual`. If the result of `dependsOnEqual` is false, there is no problem. If the result of `dependsOnEqual` is true, need to check the diffs of other properties.
kuwa0224
force-pushed
the
feature/fix_bug_10322
branch
from
cb3c666 to
edf6798
Compare
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10322
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license