Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@aws-cdk/aws-lambda-nodejs] containerEnvironment is in the README, but is not implemented #10443

Closed
winjer opened this issue Sep 19, 2020 · 2 comments · Fixed by #10457
Closed
Assignees
Labels
@aws-cdk/aws-lambda-nodejs bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@winjer
Copy link

winjer commented Sep 19, 2020

The docs say:

Use the containerEnvironment prop to pass environments variables to the Docker container running Parcel:

new lambda.NodejsFunction(this, 'my-handler', {
  containerEnvironment: {
    NODE_ENV: 'production',
  },
});

But this is not implemented.

Environment

  • CLI Version :
  • Framework Version: 1.63.0
  • Node.js Version:
  • OS :
  • Language (Version):

Other


This is 🐛 Bug Report

@winjer winjer added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 19, 2020
@jogold
Copy link
Contributor

jogold commented Sep 21, 2020

It's parcelEnvironment, the doc will be updated.

/**
* Environment variables defined when Parcel runs.
*
* @default - no environment variables are defined.
*/
readonly parcelEnvironment?: { [key: string]: string; };

jogold added a commit to jogold/aws-cdk that referenced this issue Sep 21, 2020
@mergify mergify bot closed this as completed in #10457 Sep 21, 2020
mergify bot pushed a commit that referenced this issue Sep 21, 2020
Closes #10443


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@winjer
Copy link
Author

winjer commented Sep 22, 2020

thanks! i failed to guess this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda-nodejs bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants