Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[init-templates] migrate Java init templates to JUnit 5 #10694

Closed
1 of 2 tasks
RomainMuller opened this issue Oct 5, 2020 · 2 comments · Fixed by #11101
Closed
1 of 2 tasks

[init-templates] migrate Java init templates to JUnit 5 #10694

RomainMuller opened this issue Oct 5, 2020 · 2 comments · Fixed by #11101
Assignees
@shivlaks
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. language/java Related to Java bindings p2 package/tools Related to AWS CDK Tools or CLI

Comments

@RomainMuller
Copy link
Contributor

The Java init templates include unit tests that are built against JUnit 4 (as can be seen via #10670). This is getting a little old and it might be a good idea to upgrade to JUnit 5.

Use Case

It's silly to start a new project on an older version of frameworks / tools.

Proposed Solution

Upgrade dependency to JUnit 5, and adjust the test code accordingly.
This ought to be pretty straight-forward since those tests are nothing fancy.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@RomainMuller RomainMuller added language/java Related to Java bindings feature-request A feature should be added or improved. package/tools Related to AWS CDK Tools or CLI needs-triage This issue or PR still needs to be triaged. labels Oct 5, 2020
@shivlaks shivlaks added p2 effort/small Small work item – less than a day of effort labels Oct 15, 2020
@shivlaks
Copy link
Contributor

sounds like a good idea! feel free to throw it into progress if you're already on it!

@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Oct 19, 2020
@shivlaks shivlaks mentioned this issue Oct 26, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Oct 26, 2020
@mergify mergify bot closed this as completed in #11101 Oct 28, 2020
mergify bot pushed a commit that referenced this issue Oct 28, 2020
@sullis
feat(init-templates): Java init template tests updated to JUnit 5 (#1…
e0c00a1 
…1101)

closes #10694

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivlaks shivlaks

Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. language/java Related to Java bindings p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(init-templates): Java init template tests updated to JUnit 5 sullis/aws-cdk
3 participants
@RomainMuller @SomayaB @shivlaks