Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rds] Add more entries for MysqlEngineVersionmodule #10756

Closed
2 tasks
neilkuan opened this issue Oct 7, 2020 · 1 comment · Fixed by #10757
Closed
2 tasks

[rds] Add more entries for MysqlEngineVersionmodule #10756

neilkuan opened this issue Oct 7, 2020 · 1 comment · Fixed by #10757
Assignees
@skinny85
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@neilkuan
Copy link
Contributor

neilkuan commented Oct 7, 2020

Add more entries for MysqlEngineVersion:

aws-cdk/packages/@aws-cdk/aws-rds/lib/instance-engine.ts

Lines 347 to 353 in 459488d

public static readonly VER_8_0_16 = MysqlEngineVersion.of('8.0.16', '8.0');
/** Version "8.0.17". */
public static readonly VER_8_0_17 = MysqlEngineVersion.of('8.0.17', '8.0');
/** Version "8.0.19". */
public static readonly VER_8_0_19 = MysqlEngineVersion.of('8.0.19', '8.0');
/** 

aws rds describe-db-engine-versions --engine mysql | jq -r '.DBEngineVersions[] | [.Engine, .EngineVersion]'
[
  "mysql",
  "8.0.16"
]
[
  "mysql",
  "8.0.17"
]
[
  "mysql",
  "8.0.19"
]
[
  "mysql",
  "8.0.20"
]

Use Case

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@neilkuan neilkuan added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 7, 2020
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Oct 7, 2020
@neilkuan neilkuan mentioned this issue Oct 7, 2020
Merged
@mergify mergify bot closed this as completed in #10757 Oct 7, 2020
mergify bot pushed a commit that referenced this issue Oct 7, 2020
@neilkuan
chore(rds): add additional mysql engine versions (#10757)
8b9a5cf 
chore(rds): add additional mysql engine versions
Closes: #10756

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Oct 7, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(rds): add additional mysql engine versions
2 participants
@skinny85 @neilkuan