Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): asset used in multiple Stages is only bundled in the first Stage #10957

Closed
wants to merge 5 commits into from
Closed

fix(core): asset used in multiple Stages is only bundled in the first Stage #10957

wants to merge 5 commits into from

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Oct 19, 2020

Always stage assets in the outdir of the top level Stage/App.

Closes #10877

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jogold
fix(core): bundling of assets used in multiple Stages
a628edf 
Always stage assets in the outdir of the top level Stage/App.

Closes aws#10877
@gitpod-io
Copy link

gitpod-io bot commented Oct 19, 2020 •
edited
Loading

@jogold
Copy link
Contributor Author

jogold commented Oct 19, 2020

@rix0rrr what about this simple fix?

@jogold jogold changed the title fix(core): bundling of assets used in multiple Stages fix(core): asset used in multiple Stages is only bundled in the first Stage Oct 19, 2020
@rix0rrr rix0rrr self-assigned this Oct 19, 2020
@jogold
Copy link
Contributor Author

jogold commented Oct 19, 2020

@misterjoshua why do I need to update the integ tests in aws-lambda-python after the change in core here?

@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 19, 2020

I'm brewing something myself as well. Thanks for providing your take, once I'm done I'm going to compare and contrast :).

@misterjoshua
Copy link
Contributor

@misterjoshua why do I need to update the integ tests in aws-lambda-python after the change in core here?

I'll take a look.

@misterjoshua
Copy link
Contributor

@jogold It looks like the emitted asset changed from the pip install in a recent version of the sam build containers in question. This looks like it's blocking #10958 now too.

@misterjoshua misterjoshua mentioned this pull request Oct 19, 2020
Merged
mergify bot pushed a commit that referenced this pull request Oct 19, 2020
@misterjoshua
fix(lambda-python): asset hashes changed (#10959)
b8de264 
Fixes the issue with the lambda python asset hashes changing. The dependencies of the `requests` package need to be explicitly locked.

See broken builds in #10958, #10957

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@misterjoshua
Copy link
Contributor

@jogold It looks like the emitted asset changed from the pip install in a recent version of the sam build containers in question. This looks like it's blocking #10958 now too.

@jogold We've merged a fix which I hope should help.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7ff0041
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jogold
Copy link
Contributor Author

jogold commented Oct 21, 2020

Closing in favor of #11008

@jogold jogold closed this Oct 21, 2020
@jogold jogold deleted the stage-top-level branch October 21, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pipelines] 1.67.0 breaks custom asset bundling when using multiple pipelines
4 participants
@jogold @rix0rrr @misterjoshua @aws-cdk-automation