Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-python): asset hashes changed #10959

Merged

Conversation

misterjoshua
Copy link
Contributor

@misterjoshua misterjoshua commented Oct 19, 2020

Fixes the issue with the lambda python asset hashes changing. The dependencies of the requests package need to be explicitly locked.

See broken builds in #10958, #10957


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 19, 2020

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 45e612b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@misterjoshua misterjoshua marked this pull request as ready for review October 19, 2020 17:39
@misterjoshua
Copy link
Contributor Author

@jogold Here's a PR that fixes the issue you noticed in #10957

@misterjoshua misterjoshua changed the title fix(lambda-python-layers): asset hashes changed fix(lambda-python): asset hashes changed Oct 19, 2020
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @misterjoshua !

@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b8de264 into aws:master Oct 19, 2020
@misterjoshua misterjoshua deleted the lambda-python-layers-asset-hash-changed branch October 19, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants