Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RDS] OracleEngineVersion.class is has only outdated minor versions #11066

Closed
magnusalstad opened this issue Oct 23, 2020 · 2 comments · Fixed by #11077
Closed

[RDS] OracleEngineVersion.class is has only outdated minor versions #11066

magnusalstad opened this issue Oct 23, 2020 · 2 comments · Fixed by #11077
Assignees
@skinny85
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@magnusalstad
Copy link

❓ General Issue

The latest Java cdk (1.69) is missing the latest minor versions:
https://docs.aws.amazon.com/cdk/api/latest/java/index.html?software/amazon/awscdk/services/rds/OracleEngineVersion.html
OracleEngineVersion class lists 12.2.0.1.ru-2020-04.rur-2020-04.r1, 18.0.0.0.ru-2020-04.rur-2020-04.r1 and 12.2.0.1.ru-2020-04.rur-2020-04.r1 as latest version, I'm missing the latest ones documented here: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Appendix.Oracle.PatchComposition.html
2020 July | 19.0.0.0.ru-2020-07.rur-2020-07.r1 | 18.0.0.0.ru-2020-07.rur-2020-07.r1 | 12.2.0.1.ru-2020-07.rur-2020-07.r1

The Question

When can we expect the OracleEngineVersion class to be updated with the current minor versions?

Environment

  • CDK CLI Version: 1.69
  • Module Version: RDS
  • Language (Version): Java
@magnusalstad magnusalstad added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Oct 23, 2020
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Oct 23, 2020
@skinny85
Copy link
Contributor

Hey @magnusalstad ,

this should be a simple change, adding the new constants to the OracleEngineVersion class, similar to other Pull Requests that added these ([1], [2]). Any chance you could submit a change like that to our project? Our contributor documentation is here.

In the meantime, you can use the of static factory method of the OracleEngineVersion class to create an arbitrary version.

Thanks,
Adam

@skinny85 skinny85 added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2 and removed guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Oct 23, 2020
@AnderEnder AnderEnder mentioned this issue Oct 23, 2020
Merged
@mergify mergify bot closed this as completed in #11077 Oct 23, 2020
mergify bot pushed a commit that referenced this issue Oct 23, 2020
@AnderEnder
chore(rds): add additional minor versions for engines (#11077)
a6439a1 
Add additional minor versions for engines

Closes #11066

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(rds): add additional minor versions for engines AnderEnder/aws-cdk
2 participants
@skinny85 @magnusalstad