-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: split to a maven package per CDK package #111
Comments
Related to aws/jsii#73 |
eladb
pushed a commit
that referenced
this issue
Aug 1, 2018
Setup a "package" npm script in all modules (via pkglint) to perform packaging for the module: If this is a jsii module, jsii-pacmak is invoked, which now generates and builds the module for all target languages. Output goes to `dist/npm`, `dist/java` and `dist/dotnet`. If this is not a jsii module, we invoke 'npm pack' and move the tarball to `dist/npm` (so it looks like the jsii output). aws-cdk-docs dist/ directory modified to only contain a `docs/` output (staging moved out). Private modules don't have a "package" script. Updated pack.sh to simply call "lerna run package", which will result in "dist/" directories with artifacts throughput the repo. Now, we merge all dist/ directories into "./pack/" and bundle-beta.sh will use it as the base for the distribution zip file (implemented in `pack-collect.sh`) The distribution zip file still supports y-npm based installation, but it's structure is now: aws-cdk-${version}.zip │ ├─ bin ├─ node_modules ├─ y │ └─ npm - y-npm repository for local installs (duplicate tarballs) │ ├─ docs - rendered docsite ├─ npm - npm tarballs ├─ dotnet - nuget packages ├─ java - maven repository │ └─ .version Fixes #111
Merged
eladb
pushed a commit
that referenced
this issue
Aug 2, 2018
Setup a "package" npm script in all modules (via pkglint) to perform packaging for the module: If this is a jsii module, jsii-pacmak is invoked, which now generates and builds the module for all target languages. Output goes to `dist/npm`, `dist/java` and `dist/dotnet`. If this is not a jsii module, we invoke 'npm pack' and move the tarball to `dist/npm` (so it looks like the jsii output). aws-cdk-docs dist/ directory modified to only contain a `docs/` output (staging moved out). Private modules don't have a "package" script. Updated pack.sh to simply call "lerna run package", which will result in "dist/" directories with artifacts throughput the repo. Now, we merge all dist/ directories into "./pack/" and bundle-beta.sh will use it as the base for the distribution zip file (implemented in `pack-collect.sh`) The distribution zip file still supports y-npm based installation, but it's structure is now: aws-cdk-${version}.zip │ ├─ bin ├─ node_modules ├─ y │ └─ npm - y-npm repository for local installs (duplicate tarballs) │ ├─ docs - rendered docsite ├─ npm - npm tarballs ├─ dotnet - nuget packages ├─ java - maven repository │ └─ .version Fixes #111 Also: * Don't build java example for now, we need to turn it into an integration test. * Bundle the jsii java runtime w/ other java packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment, we produce one big maven module com.amazon.aws/aws-cdk which contains the entire CDK (all public modules in this repository). We would like to vend multiple maven packages so that each CDK module can evolve independently. This is especially important to not require major version bumps of everything if only one module had a breaking change.
The text was updated successfully, but these errors were encountered: