Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elasticsearch] Incorrect Search/IndexingLatency metrics #11174

Closed
arkon opened this issue Oct 28, 2020 · 1 comment · Fixed by #11175
Closed

[elasticsearch] Incorrect Search/IndexingLatency metrics #11174

arkon opened this issue Oct 28, 2020 · 1 comment · Fixed by #11175
Assignees
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1

Comments

@arkon
Copy link
Contributor

arkon commented Oct 28, 2020

The metrics used are currently incorrect, i.e.

  • SearchLatencyP99 should be SearchLatency
  • IndexingLatencyP99 should be IndexingLatency

Code:

/**
* Metric for search latency.
*
* @default p99 over 5 minutes
*/
public metricSearchLatency(props?: MetricOptions): Metric {
return this.metric('SearchLatencyP99', { statistic: 'p99', ...props });
}
/**
* Metric for indexing latency.
*
* @default p99 over 5 minutes
*/
public metricIndexingLatency(props?: MetricOptions): Metric {
return this.metric('IndexingLatencyP99', { statistic: 'p99', ...props });
}

Metrics documentation: https://docs.aws.amazon.com/elasticsearch-service/latest/developerguide/es-managedomains-cloudwatchmetrics.html

Reproduction Steps

What did you expect to happen?

Create alarms using Metrics with the related CloudWatch metrics.

What actually happened?

Got alarms using invalid Metrics that don't display anything as the metric names do not exist.

Environment

  • CLI Version : >= 1.65.0
  • Framework Version: >= 1.65.0
  • Node.js Version: any
  • OS : any
  • Language (Version): all

Other

Originally added in #8369


This is 🐛 Bug Report

@arkon arkon added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 28, 2020
@github-actions github-actions bot added the @aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service label Oct 28, 2020
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Oct 28, 2020
@iliapolo iliapolo added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 8, 2020
@mergify mergify bot closed this as completed in #11175 Nov 8, 2020
mergify bot pushed a commit that referenced this issue Nov 8, 2020
Fixes #11174

As per the issue details, this uses the correct metric names as described in [the documentation](https://docs.aws.amazon.com/elasticsearch-service/latest/developerguide/es-managedomains-cloudwatchmetrics.html).

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Nov 8, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants