-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdk init: rename "dotnet" to "csharp" #1123
Comments
@eladb Can I work on this ? it seems only this below directory needs to be changed for this |
Thanks so much for proposing. And you are correct in your approach. Technically this is all that needs to be changed in the CDK repo, but we have a bunch of integration tests for "cdk init" in another repo that also must be updated. Perhaps what we can do is copy & paste the "dotnet" directory into "csharp" so the change will be backwards compatible and then we can update our integration tests and deprecate "dotnet". |
@eladb that would be a good idea. I Can start making the changes in my branch if it's fine with you. Can you provide the integration test repo url so that I can update them? |
Go ahead, much appreciated |
@eladb Can you please let me know the location for the integration tests ? |
Our integration tests are mastered in a private repo. Let's just start with duplicating "dotnet" to "csharp" and we'll take it from there. |
@eladb got it ... I will create the PR for this |
The 'dotnet' template should more properly be called 'csharp', since that's the actual name of the language in which it is written. Fixes #1123.
The 'dotnet' template should more properly be called 'csharp', since that's the actual name of the language in which it is written. Fixes #1123.
The 'dotnet' template should more properly be called 'csharp', since that's the actual name of the language in which it is written. Fixes #1123.
Because it's a C# project
The text was updated successfully, but these errors were encountered: