Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[transfer] SecurityGroupIds propertie missing in interface EndpointDetailsProperty #11275

Closed
2 tasks
Cloudrage opened this issue Nov 3, 2020 · 4 comments · Fixed by #11319
Closed
2 tasks
Assignees
Labels
@aws-cdk/aws-transfer Related to AWS Transfer for SFTP effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@Cloudrage
Copy link

Use Case

Need to configure a Security Group for a SFTP Transfer in VPC type like availabe in Cloudformation :
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-transfer-server-endpointdetails.html#cfn-transfer-server-endpointdetails-securitygroupids

Proposed Solution

Add SecurityGroupIds prop in AWS::Transfer::Server EndpointDetails.

Other

If not provided, default VPC SGR is used; and it's not the idea :)

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@Cloudrage Cloudrage added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 3, 2020
@github-actions github-actions bot added the @aws-cdk/aws-transfer Related to AWS Transfer for SFTP label Nov 3, 2020
@iliapolo
Copy link
Contributor

iliapolo commented Nov 9, 2020

Should be available once spec 20.0.0 is merged.

@iliapolo iliapolo added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 9, 2020
@Cloudrage
Copy link
Author

Hello @iliapolo,

Many thanks about that.
I've a question, maybe another request to open :
Since few months, it's not possible to create VPC_ENDPOINT type for Transfer, but VPC.

It'll create a VPC Endpoint on our behalf, but how to get the "ID" and/or "DNS" names of this endpoint ?
No outputs with that in Cfn/CDK :
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-transfer-server.html#aws-resource-transfer-server-return-values

Need it to access the SFTP Server and for example, create a R53 record on it.
s-xxxxxxxxxxxx.server.transfer.region.amazonaws.com don't work in private VPC server.

@mergify mergify bot closed this as completed in #11319 Nov 11, 2020
mergify bot pushed a commit that referenced this issue Nov 11, 2020
Following are open issues for missing properties that will be added with the update:

- Closes #11275
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@iliapolo
Copy link
Contributor

Discussion moved to #11374 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-transfer Related to AWS Transfer for SFTP effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants