Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet-facing ALBs need ordering dependency on InernetGateway #1129

Closed
rix0rrr opened this issue Nov 8, 2018 · 0 comments · Fixed by #1284
Closed

Internet-facing ALBs need ordering dependency on InernetGateway #1129

rix0rrr opened this issue Nov 8, 2018 · 0 comments · Fixed by #1284
Assignees
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing bug This issue is a bug.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 8, 2018

Otherwise there's a race condition which may lead them to fail to create.

@rix0rrr rix0rrr added bug This issue is a bug. @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing labels Nov 8, 2018
@rix0rrr rix0rrr self-assigned this Dec 3, 2018
rix0rrr added a commit that referenced this issue Dec 4, 2018
Internet-facing load balancers can only be created once the VPC's
Internet Gateway has been created, otherwise creation is an error.

Usually the gateway is speedy enough to create so that this lack of a
dependency doesn't show, but to be correct we still need to add it.

Fixes #1129.

ALSO IN THIS CHANGE

- Add a script to visualize dependencies in a CloudFormation template
  (by converting to .dot).
rix0rrr added a commit that referenced this issue Dec 5, 2018
Internet-facing load balancers can only be created once the VPC's
Internet Gateway has been created, otherwise creation is an error.

Usually the gateway is speedy enough to create so that this lack of a
dependency doesn't show, but to be correct we still need to add it.

Fixes #1129.

ALSO IN THIS CHANGE

* Add a script to visualize dependencies in a CloudFormation template
  (by converting to .dot).
* Add a script to run integration tests in parallel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant