Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pipelines] Stage can't support more than 25 stacks #11315

Closed
JFox opened this issue Nov 5, 2020 · 4 comments
Closed

[pipelines] Stage can't support more than 25 stacks #11315

JFox opened this issue Nov 5, 2020 · 4 comments
Assignees
Labels
@aws-cdk/pipelines CDK Pipelines library bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1

Comments

@JFox
Copy link

JFox commented Nov 5, 2020

When attempting to deploy a pipeline with more than 25 stacks, the deploy fails due to the stage having more than 50 actions.

Reproduction Steps

Deploy a pipeline with > 25 stacks.

What did you expect to happen?

Deployment to succeed

What actually happened?

On deploy, the following error is hit:

Pipeline stage '<StageName>' has too many actions. There can only be up to 50 actions in a pipeline stage (Service: AWSCodePipeline; Status Code: 400; Error Code: InvalidStageDeclarationException; Request ID: xxx)

Environment

  • CLI Version : 1.71.0
  • Framework Version: 1.71.0
  • Node.js Version: 13.8.0
  • OS : MacOS
  • Language (Version): TypeScript (3.9.7)

Other

Tried to work it around by referencing cross-stage but got dependency cannot cross stage boundaries error.

Similar issue, but for assets: #9353


This is 🐛 Bug Report

@JFox JFox added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 5, 2020
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Nov 5, 2020
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort p1 labels Nov 9, 2020
@rix0rrr rix0rrr added this to the [GA] CDK Pipelines milestone Nov 9, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Nov 9, 2020
@victorlevasseur
Copy link

I really wonder if this can be fixed as it requires extra stages and stages cannot share cross references.

@victorlevasseur
Copy link

I'm currently trying to solve this issue. I'll soon create a merge request if I'm able to achieve the correct result.

victorlevasseur added a commit to victorlevasseur/aws-cdk that referenced this issue Nov 29, 2020
CdkStage can now create multiple codepipeline stages. If the stage
has not enough room remaining for the next stack, it will insert a new
stage and continue processing it. Manually added actions are also
added to the correct stage depending on their run order.

Closes aws#11315
victorlevasseur added a commit to victorlevasseur/aws-cdk that referenced this issue Nov 29, 2020
CdkStage can now create multiple codepipeline stages. If the stage
has not enough room remaining for the next stack, it will insert a new
stage and continue processing it. Manually added actions are also
added to the correct stage depending on their run order.

Closes aws#11315
victorlevasseur added a commit to victorlevasseur/aws-cdk that referenced this issue Nov 29, 2020
CdkStage can now create multiple codepipeline stages. If the stage
has not enough room remaining for the next stack, it will insert a new
stage and continue processing it. Manually added actions are also
added to the correct stage depending on their run order.

Add afterPreparation method to CdkStage to allow a function to be
executed after the CdkStage has been prepared (actions bound to their
underlying codepipeline stage).

Closes aws#11315

BREAKING CHANGE: IAction actions are bound to the underlying
codepipeline stages of the CdkStage late.
* **pipelines:** ShellScriptAction IGrantable interface can only be
used after the action is effectively bound to the stage, usage of
afterPreparation is required to use the action as an IGrantable
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Dec 7, 2020
@rix0rrr
Copy link
Contributor

rix0rrr commented Jan 7, 2021

Treated as part of #10872.

@rix0rrr rix0rrr closed this as completed Jan 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/pipelines CDK Pipelines library bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants