Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdk-pipelines] Cannot add codepipeline action within an Application Stage #11360

Closed
BenTScott opened this issue Nov 8, 2020 · 2 comments · Fixed by #11368
Closed

[cdk-pipelines] Cannot add codepipeline action within an Application Stage #11360

BenTScott opened this issue Nov 8, 2020 · 2 comments · Fixed by #11368
Assignees
@rix0rrr
Labels
@aws-cdk/pipelines CDK Pipelines library guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged.

Comments

@BenTScott
Copy link

BenTScott commented Nov 8, 2020 •
edited
Loading

❓ General Issue

Adding an action within an Application Stage

I am trying to add an application stage to my pipeline with everything required for deploying a React SPA (S3 bucket, cloudfront, API). I have everything contained within a stage. The issue I'm having is this requires an S3 deployment action. I want to keep things encapsulated and make it simple to deploy to multiple environments but I cannot find a way of having the S3 bucket within a stage and also using it in a deploy action without the following dependency cannot cross stage boundaries.

Environment

  • CDK CLI Version: 1.70
  • Module Version: 1.70
  • Node.js Version: v15.1.0
  • OS: Ubuntu
  • Language (Version): TypeScript (3.8.3)
@BenTScott BenTScott added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Nov 8, 2020
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Nov 8, 2020
@rix0rrr
Copy link
Contributor

rix0rrr commented Nov 9, 2020

That's true. It's up to you to make sure the stages are deployed in the right order, and you're going to have to find a different way to move the bucket name across domains.

Either create an SSM parameter with the bucket name, or create a CloudFormation Export and construct the { Fn::ImportValue} yourself.

rix0rrr added a commit that referenced this issue Nov 9, 2020
@rix0rrr
feat(core): add easy importValue to CfnOutput
a0f81fd 
To transport values across Stages, users need to construct their
own `{ Fn::ImportValue }` expressions, as we cannot properly do this
for them in order to keep Stages deterministic and isolated.

Add an expression constructor to make this API easier to use.

Resolves #11360.
@rix0rrr rix0rrr mentioned this issue Nov 9, 2020
Merged
@mergify mergify bot closed this as completed in #11368 Nov 13, 2020
mergify bot pushed a commit that referenced this issue Nov 13, 2020
@rix0rrr
feat(core): add easy importValue to CfnOutput (#11368)
c71a4e9 
To transport values across Stages, users need to construct their
own `{ Fn::ImportValue }` expressions, as we cannot properly do this
for them in order to keep Stages deterministic and isolated.

Add an expression constructor to make this API easier to use.

Resolves #11360.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/pipelines CDK Pipelines library guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): add easy importValue to CfnOutput aws/aws-cdk
2 participants
@rix0rrr @BenTScott