Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-applicationautoscaling] Add 'kafka' to ServiceNamespace #11366

Closed
1 of 2 tasks
iwt-janbrauer opened this issue Nov 9, 2020 · 3 comments · Fixed by #11394
Closed
1 of 2 tasks

[aws-applicationautoscaling] Add 'kafka' to ServiceNamespace #11366

iwt-janbrauer opened this issue Nov 9, 2020 · 3 comments · Fixed by #11394
Assignees
@NetaNir
Labels
@aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p1

Comments

@iwt-janbrauer
Copy link

iwt-janbrauer commented Nov 9, 2020 •
edited
Loading

To use Autoscaling storage for MSK with CDK the ServiceNamespace enum needs the additional field KAFKA.

Use Case

Because I want to use CDK.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@iwt-janbrauer iwt-janbrauer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 9, 2020
@github-actions github-actions bot added the @aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling label Nov 9, 2020
@NetaNir NetaNir added good first issue Related to contributions. See CONTRIBUTING.md p1 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 9, 2020
@NetaNir
Copy link
Contributor

NetaNir commented Nov 9, 2020 •
edited
Loading

@iwt-janbrauer would you want to submit a PR?

@bracki
Copy link
Contributor

bracki commented Nov 10, 2020

@NetaNir #11394

@bracki bracki mentioned this issue Nov 10, 2020
Merged
@mergify mergify bot closed this as completed in #11394 Nov 12, 2020
mergify bot pushed a commit that referenced this issue Nov 12, 2020
@bracki
feat(applicationautoscaling): Add KAFKA to ServiceNamespace (#11394)
b5c3f84 
Add `KAFKA` to ServiceNamespace. This allows targeting MSK's autoscaling feature.

Fixes #11366

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NetaNir NetaNir

Labels
@aws-cdk/aws-applicationautoscaling Related to AWS Application Auto Scaling feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(applicationautoscaling): Add KAFKA to ServiceNamespace bracki/aws-cdk
3 participants
@bracki @NetaNir @iwt-janbrauer