feat(core): add easy importValue to CfnOutput #11368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To transport values across Stages, users need to construct their
own `{ Fn::ImportValue }` expressions, as we cannot properly do this
for them in order to keep Stages deterministic and isolated.
Add an expression constructor to make this API easier to use.
Resolves #11360.
rix0rrr
added
the
pr-linter/exempt-readme
|
|
eladb
reviewed
Nov 10, 2020
| return Fn.importValue(Lazy.stringValue({ | ||
| produce: () => { | ||
| if (!this._exportName) { | ||
| throw new Error(`Add an exportName to the CfnOutput at '${this.node.path}' in order to use 'output.importValue'`); |
There was a problem hiding this comment.
Can't we auto-allocate an export name in this case (similar to the one we allocate for auto-refs)?
There was a problem hiding this comment.
We could, but I'm not 100% comfortable doing that yet. Doesn't seem too onerous to start by expecting people to provide a name.
| /** | ||
| * Return the `Fn.importValue` expression to import this value into another stack | ||
| * | ||
| * The returned value should not be used in the same stack, but in a |
There was a problem hiding this comment.
Can we test that this is referenced in the same stack and fail early?
eladb
approved these changes
Nov 12, 2020
| return Fn.importValue(Lazy.stringValue({ | ||
| produce: () => { | ||
| if (!this._exportName) { | ||
| throw new Error(`Add an exportName to the CfnOutput at '${this.node.path}' in order to use 'output.importValue'`); |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To transport values across Stages, users need to construct their
own
{ Fn::ImportValue }expressions, as we cannot properly do thisfor them in order to keep Stages deterministic and isolated.
Add an expression constructor to make this API easier to use.
Resolves #11360.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license