[pipelines] wrong position for ManualApproval action in cdkStage addApplication()

[adriantaut]

This is a quick bugfix for #11376. The desired actions order described in #11333 is not achieved when used with manualApprovals: true.

Desired order: Prepare ChangeSet -> Manual Approval -> ExtraAction -> Execute ChangeSet

However, the runOrder of the Manual Approval is 3 instead of 2, not being placed right after the Prepare action.

This is happening because the RunOrder of the Manual Approval action is decided by the executeRunOrder, which is already increased by the number of extra actions needed in that stage, instead of being decided by the runOrder of the Prepare ChangeSet action. (https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/pipelines/lib/stage.ts#L99)

Reproduction Steps

    cdkStage.addApplication(appStage, {
      manualApprovals: isProduction || requiresManualApproval,
      extraRunOrderSpace: isProduction ? 1 : 0,
    });

What did you expect to happen?

Having a stage with the following:

• Prepare ChangeSet action (runOrder: 1)
• Manual Approval (runOrder: 2)
• Empty Place for extra Action (runOrder: 3)
• Execute ChangeSet action (runOrder: 4)

What actually happened?

• Prepare ChangeSet action (runOrder: 1)
• Empty Place for extra Action (runOrder: 2)
• Manual Approval (runOrder: 3)
• Execute ChangeSet action (runOrder: 4)

Environment

• CDK CLI Version : 1.73.0
• Framework Version:
• Node.js Version: v14.12.0
• OS : MacOS
• Language (Version): 3.7.3

Other

I will implement the bugfix since the original PR was missing this functionality.

---

This is 🐛 Bug Report

[adriantaut]

fix implemented in #11511

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.