Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dynamodb] missing metricSystemErrorsForOperations in ITable #11541

Closed
abragx opened this issue Nov 18, 2020 · 6 comments · Fixed by #11980
Closed

[dynamodb] missing metricSystemErrorsForOperations in ITable #11541

abragx opened this issue Nov 18, 2020 · 6 comments · Fixed by #11980
Assignees
@skinny85
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@abragx
Copy link

abragx commented Nov 18, 2020 •
edited by SomayaB
Loading

metricSystemErrorsForOperations is missing in dynamodb.ITable

Reproduction Steps

See comment below

look here in ITable definition

What did you expect to happen?

the method is there

What actually happened?

the method is not there

Environment

  • CDK CLI Version : 1.74.0
  • Framework Version:
  • Node.js Version: 10.19.0
  • OS : ubuntu
  • Language (Version): TypeScript

This is 🐛 Bug Report
@abragx abragx added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 18, 2020
@robertd
Copy link
Contributor

robertd commented Nov 18, 2020 •
edited
Loading

@abragx Can you please paste the code on how to reproduce this error?

I'm getting the metricSystemErrorsForOperations method to show up on my table object.

image

@abragx
Copy link
Author

abragx commented Nov 19, 2020

yes, but I am talking about the interface

image

@SomayaB SomayaB changed the title Typescript [1.74.0] - missing metricSystemErrorsForOperations in ITable [dynamodb] missing metricSystemErrorsForOperations in ITable Nov 20, 2020
@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label Nov 20, 2020
@SomayaB
Copy link
Contributor

SomayaB commented Nov 20, 2020

@abragx The metricSystemErrorsForOperations method only exists as a method of the class Table and not the ITable interface.

@abragx
Copy link
Author

abragx commented Nov 20, 2020

I know, that's why I raised the bug report.

@skinny85
Copy link
Contributor

skinny85 commented Dec 5, 2020

@abragx this should be a simple fix by adding the metricSystemErrorsForOperations method to the ITable interface (the implementation is already in the correct TableBase class). Would you mind submitting us a PR with the fix? Here's our Contributing guide: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md .

Thanks,
Adam

@skinny85 skinny85 added effort/small Small work item – less than a day of effort p2 good first issue Related to contributions. See CONTRIBUTING.md and removed needs-triage This issue or PR still needs to be triaged. labels Dec 5, 2020
ktheory added a commit to ktheory/aws-cdk that referenced this issue Dec 10, 2020
@ktheory
chore(dynamodb): add metricSystemErrorsForOperations to ITable
0fa0e36 
Adds `metricSystemErrorsForOperations` and `metricThrottledRequests` to the `ITable` interface. Previously they were just in the `Table` class.

Thx @SomayaB and @skinny85 for highlighting the fix.

Fixes aws#11541
@ktheory ktheory mentioned this issue Dec 10, 2020
Merged
@mergify mergify bot closed this as completed in #11980 Dec 10, 2020
mergify bot pushed a commit that referenced this issue Dec 10, 2020
@ktheory
chore(dynamodb): add metricSystemErrorsForOperations to ITable (#11980)
9cd76cd 
Adds `metricSystemErrorsForOperations` and `metricThrottledRequests` to the `ITable` interface. Previously they were just in the `Table` class.

Thx @SomayaB and @skinny85 for highlighting the fix.

Fixes #11541


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
@ktheory @flochaz
chore(dynamodb): add metricSystemErrorsForOperations to ITable (aws#1…
0eb1462 
…1980)

Adds `metricSystemErrorsForOperations` and `metricThrottledRequests` to the `ITable` interface. Previously they were just in the `Table` class.

Thx @SomayaB and @skinny85 for highlighting the fix.

Fixes aws#11541


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(dynamodb): add metricSystemErrorsForOperations to ITable ktheory/aws-cdk
4 participants
@robertd @skinny85 @SomayaB @abragx