feat(lambda-event-sources): batching window for sqs event source #11724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
nija-at
previously requested changes
Nov 30, 2020
nija-at
changed the title
nija-at
changed the title
jogold
reviewed
Dec 7, 2020
mergify
bot
dismissed
nija-at’s stale review
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
nija-at
suggested changes
Jan 6, 2021
| * | ||
| * Valid Range: Minimum value of 0 minutes. Maximum value of 5 minutes. | ||
| * | ||
| * @default Duration.seconds(0) |
There was a problem hiding this comment.
Better to say something like this -
Suggested change
| * @default Duration.seconds(0) | |
| * @default - no batching window. The lambda function will be invoked immediately with the records that are available. |
Comment on lines
+47
to
+48
| if (maxBatchingWindow.toSeconds() < 0 || maxBatchingWindow.toSeconds() > 300) { | ||
| throw new Error(`Maximum batching window must be between 0 and 300 seconds (given ${maxBatchingWindow.toSeconds()})`); |
There was a problem hiding this comment.
AFAIK, it's not possible to construct a Duration that is less than 0 seconds.
Suggested change
| if (maxBatchingWindow.toSeconds() < 0 || maxBatchingWindow.toSeconds() > 300) { | |
| throw new Error(`Maximum batching window must be between 0 and 300 seconds (given ${maxBatchingWindow.toSeconds()})`); | |
| if (maxBatchingWindow.toSeconds() > 300) { | |
| throw new Error(`Maximum batching window must be 300 seconds or less (given ${maxBatchingWindow.toSeconds()})`); |
| const stack = new cdk.Stack(); | ||
| const fn = new TestFunction(stack, 'Fn'); | ||
| const q = new sqs.Queue(stack, 'Q'); | ||
| let batchSize : number; |
There was a problem hiding this comment.
Suggested change
| let batchSize : number; | |
| const batchSize: number = 500; |
|
What is the status on this making it into CDK? my team is waiting on this new feature. |
|
Looks like this PR has not been worked on for several months. @cbenning - if you're interested, you could pick this up and get it past the finish line. |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Mar 31, 2021
|
closing this PR in favor of #13406 |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11722
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license