Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda-event-sources): support for batching window to sqs event source #13406

Merged
merged 3 commits into from
Mar 26, 2021
Merged

feat(lambda-event-sources): support for batching window to sqs event source #13406

merged 3 commits into from
Mar 26, 2021

Conversation

stefanodesjo
Copy link
Contributor

@stefanodesjo stefanodesjo commented Mar 4, 2021 •
edited by nija-at
Loading

Fixes #11722

This is continued work from #11724

closes #13770

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 4, 2021 •
edited
Loading

@github-actions github-actions bot added @aws-cdk/aws-lambda-event-sources @aws-cdk/aws-sqs Related to Amazon Simple Queue Service labels Mar 4, 2021
@stefanodesjo stefanodesjo force-pushed the feat/sqs-batching-window-support branch 4 times, most recently from 0c04c62 to c520e5d Compare March 8, 2021 15:13
@stefanodesjo
Copy link
Contributor Author

@nija-at @MrArnoldPalmer Anything remaining to get an approval?

@nija-at
Copy link
Contributor

nija-at commented Mar 17, 2021

Hello -

Sorry about the delay in reviewing PRs. We are experiencing an increased backlog of items that need our attention.
We will get to your PR as soon as we are able to. Apologies for the delay.

nija-at
nija-at previously requested changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stefanodesjo - Thanks for submitting this PR.

See some of my comments below.

packages/@aws-cdk/aws-lambda-event-sources/lib/sqs.ts Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/lib/sqs.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/lib/sqs.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/lib/sqs.ts Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/README.md Show resolved Hide resolved
@stefanodesjo stefanodesjo force-pushed the feat/sqs-batching-window-support branch from c520e5d to fb65917 Compare March 22, 2021 21:04
@mergify mergify bot dismissed nija-at’s stale review March 22, 2021 21:04

Pull request has been modified.

@stefanodesjo stefanodesjo force-pushed the feat/sqs-batching-window-support branch 5 times, most recently from 52dde51 to 82357ef Compare March 24, 2021 15:23
nija-at
nija-at previously requested changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @stefanodesjo -

Looks like you misunderstood my previous comments. See below.

packages/@aws-cdk/aws-lambda-event-sources/lib/sqs.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/lib/sqs.ts Outdated Show resolved Hide resolved
@stefanodesjo stefanodesjo force-pushed the feat/sqs-batching-window-support branch from 82357ef to 303b468 Compare March 25, 2021 07:19
@mergify mergify bot dismissed nija-at’s stale review March 25, 2021 07:20

Pull request has been modified.

nija-at
nija-at previously requested changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the PR. See my comments below.

Could you also look at the failing build and fix it? The logs to the failing build are available in the automated comment above.

packages/@aws-cdk/aws-lambda-event-sources/lib/sqs.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/test/test.sqs.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/test/test.sqs.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/test/test.sqs.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/test/test.sqs.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/test/test.sqs.ts Outdated Show resolved Hide resolved
@nija-at nija-at changed the title feat(lambda-event-sources): add support for batching window to sqs event source feat(lambda-event-sources): support for batching window to sqs event source Mar 25, 2021
@stefanodesjo stefanodesjo force-pushed the feat/sqs-batching-window-support branch from 303b468 to 57eac86 Compare March 25, 2021 13:19
@mergify mergify bot dismissed nija-at’s stale review March 25, 2021 13:20

Pull request has been modified.

@stefanodesjo stefanodesjo force-pushed the feat/sqs-batching-window-support branch 3 times, most recently from 76969db to e8ce8aa Compare March 25, 2021 15:26
@stefanodesjo stefanodesjo force-pushed the feat/sqs-batching-window-support branch from e8ce8aa to 2876e3b Compare March 25, 2021 15:59
@mergify
Copy link
Contributor

mergify bot commented Mar 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@nija-at nija-at mentioned this pull request Mar 26, 2021
Closed
2 tasks
@mergify
Copy link
Contributor

mergify bot commented Mar 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 81e09a9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6743e3b into aws:master Mar 26, 2021
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Mar 31, 2021
@stefanodesjo @hollanddd
feat(lambda-event-sources): support for batching window to sqs event …
84bb4b0 
…source (aws#13406)

Fixes aws#11722

This is continued work from aws#11724

closes aws#13770

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@mckalexee
Copy link

@stefanodesjo @nija-at

Thanks for the quick turnaround here! 🙏

I really appreciate it.

@SeekerWing SeekerWing mentioned this pull request Jun 9, 2021
Closed
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@stefanodesjo @hollanddd
feat(lambda-event-sources): support for batching window to sqs event …
e8e86f1 
…source (aws#13406)

Fixes aws#11722

This is continued work from aws#11724

closes aws#13770

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@MrArnoldPalmer MrArnoldPalmer

@nija-at nija-at

Labels
@aws-cdk/aws-lambda-event-sources @aws-cdk/aws-sqs Related to Amazon Simple Queue Service
Projects
None yet
Milestone
No milestone
5 participants
@stefanodesjo @nija-at @aws-cdk-automation @mckalexee @MrArnoldPalmer