Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax constraints for construct names #12

Closed
eladb opened this issue May 31, 2018 · 1 comment
Closed

Relax constraints for construct names #12

eladb opened this issue May 31, 2018 · 1 comment
Labels
feature-request A feature should be added or improved.

Comments

@eladb
Copy link
Contributor

eladb commented May 31, 2018

At the moment, construct names are limited to only alphanumeric characters. This was due to coupling we had between construct names and CloudFormation resource logical IDs. But this has changed, since now we have a transformation function that takes a construct's path and allocates a logical ID for it. This means that we can now relax our constraints for construct names to anything other than "/" (which represents that path separator). This is useful since it is becoming increasingly common to reuse the name for other things (i.e. domain names in HostedZones, singleton unique id of a custom resource lambda function, etc).
@eladb eladb mentioned this issue Jun 5, 2018
Merged
@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 17, 2018

This has been implemented already.

@rix0rrr rix0rrr closed this as completed Sep 17, 2018
@srchase srchase added feature-request A feature should be added or improved. and removed enhancement labels Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RomainMuller @rix0rrr @eladb @srchase