Change Custom Resource mechanism to make Lambda explicit #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing `SingletonLambda` which can be instantiated multiple times but only adds the Lambda to the underlying stack once. A CustomResource now explicitly takes either a `LambdaRef` or a `TopicRef`, and the Lambda can be a SingletonLambda. This splitting up makes it possible to establish bidirectional permissions between the Custom Resource Lambda and other resources.
|
The inevitable question here is going to be, "why is SingletonLambda in |
eladb
approved these changes
Jun 5, 2018
| constructor(parent: Construct, name: string, props: SingletonLambdaProps) { | ||
| super(parent, name); | ||
|
|
||
| this.lambdaFunction = this.ensureLambda(slugify(props.uuid), props); |
There was a problem hiding this comment.
I'd call slugify inside ensureLambda (especially given the name of the param is uuid).
Also, #12
There was a problem hiding this comment.
I mean, yeah, but that's not done yet, so neither is this :)
| this.functionName = this.lambdaFunction.functionName; | ||
| this.role = this.lambdaFunction.role; | ||
|
|
||
| this.canCreatePermissions = true; // Doesn't matter, addPermission is overriden anyway |
There was a problem hiding this comment.
So why do we need to specify?
There was a problem hiding this comment.
Because it's abstract in the parent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing
SingletonLambdawhich can be instantiated multiple timesbut only adds the Lambda to the underlying stack once.
A CustomResource now explicitly takes either a
LambdaRefor aTopicRef,and the Lambda can be a SingletonLambda.
This splitting up makes it possible to establish bidirectional permissions
between the Custom Resource Lambda and other resources, as discussed in #9.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.