Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ec2): Support for new EBS types released in re:Invent 2020. #12071

Closed
1 of 2 tasks
leandrodamascena opened this issue Dec 14, 2020 · 10 comments · Fixed by #12074
Closed
1 of 2 tasks

(ec2): Support for new EBS types released in re:Invent 2020. #12071

leandrodamascena opened this issue Dec 14, 2020 · 10 comments · Fixed by #12074
Assignees
@rix0rrr
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@leandrodamascena
Copy link
Contributor

Related #12020.

I'm migrating some customers from GP2 to GP3 and I can't do it because CDK doesn't support this new EBS types. Even in the latest CDK Version (1.78.0) there is no way to use this.. On the other hand, Cloudformation already supports these new EBS types.

Use Case

Because I need perform a migration from gp2 to gp3 and this customer uses CDK to automate infra.

Proposed Solution

Add new EBS types in the next release.

Other

aws-cdk/packages/@aws-cdk/aws-ec2/lib/volume.ts

Line 201 in 889d089

export enum EbsDeviceVolumeType {

image

And yes, Cloudformation already supports this format.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volume.html
image

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@leandrodamascena leandrodamascena added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 14, 2020
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Dec 14, 2020
@leandrodamascena leandrodamascena changed the title (ec2): Support for new disk types released in re:Invent 2020. (ec2): Support for new EBS types released in re:Invent 2020. Dec 14, 2020
@NetaNir NetaNir added good first issue Related to contributions. See CONTRIBUTING.md effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Dec 14, 2020
@NetaNir
Copy link
Contributor

NetaNir commented Dec 14, 2020

Want to submit a PR with the addition? Feel free to mention me and I'll review it

@leandrodamascena
Copy link
Contributor Author

Ok @NetaNir. I think I can do it today.

Thank you for your quick reply.

leandrodamascena added a commit to leandrodamascena/aws-cdk that referenced this issue Dec 14, 2020
@leandrodamascena
feat(ec2): Support for new EBS types
ffef11e 
Added new EBS types released in re:Invent 2020 and fixed some documentation problems closes aws#12071
@leandrodamascena leandrodamascena mentioned this issue Dec 14, 2020
Merged
@SomayaB SomayaB added the p2 label Dec 21, 2020
leandrodamascena added a commit to leandrodamascena/aws-cdk that referenced this issue Dec 28, 2020
@leandrodamascena
feat(ec2): Support for new EBS types
d3ccef6 
Removed unnecessary tests. closes aws#12071
@leandrodamascena
Copy link
Contributor Author

hi @NetaNir, good night! I hope you are good.

Do you have any idea when this issue/PR will be merged into the master and released? I am currently using a custom CDK build to support this in my stacks.

Thank you in advance.

@NetaNir
Copy link
Contributor

NetaNir commented Jan 20, 2021

It seems like the build is failing

@leandrodamascena
Copy link
Contributor Author

It seems like the build is failing

Hmm maybe this? It doesn't happen here, but let me check

(0.2s)
@aws-cdk/aws-config: $ cdk-test
@aws-cdk/aws-rds: /codebuild/output/src739095591/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-rds/lib/instance.ts
@aws-cdk/aws-rds: 289:5 error Trailing spaces not allowed no-trailing-spaces
@aws-cdk/aws-rds: 292:1 error Trailing spaces not allowed no-trailing-spaces
@aws-cdk/aws-rds: ✖ 2 problems (2 errors, 0 warnings)
@aws-cdk/aws-rds: 2 errors and 0 warnings potentially fixable with the --fix option.
@aws-cdk/aws-rds: Error: /codebuild/output/src739095591/src/github.com/aws/aws-cdk/node_modules/eslint/bin/eslint.js . --ext=.ts --resolve-plugins-relative-

@NetaNir
Copy link
Contributor

NetaNir commented Jan 20, 2021

#12074 (comment)

leandrodamascena added a commit to leandrodamascena/aws-cdk that referenced this issue Jan 20, 2021
@leandrodamascena
feat(ec2): Support for new EBS types
9ecf7b1 
Removed Trailing spaces. closes aws#12071
@leandrodamascena
Copy link
Contributor Author

#12074 (comment)

Now I think it's ok. Sorry for wasting your time, but it didn't happen here.

#12074 comment)

@NetaNir
Copy link
Contributor

NetaNir commented Jan 21, 2021

You did no such thing. Hope to see you on more PRs!

@leandrodamascena
Copy link
Contributor Author

Thank you for your kindness and be sure that I'll! I use CDK every day at my company and personal projects.

@mergify mergify bot closed this as completed in #12074 Jan 21, 2021
mergify bot pushed a commit that referenced this issue Jan 21, 2021
@leandrodamascena
feat(ec2): Support for new EBS types (#12074)
6a2ce55 
closes #12071

Added new EBS types released in re:Invent 2020 and fixed some documentation problems.  Some observations:

./packages/@aws-cdk/aws-elasticsearch/lib/domain.ts - The Elasticsearch service allows only General Purpose, Provisioned IOPS and Magnetic. 
./packages/@aws-cdk/aws-rds/lib/instance.ts - Storage types and the official link were added

For compatibility reasons, I kept the " GENERAL_PURPOSE_SSD" as GP2 and created a new type called "GENERAL_PURPOSE_SSD_GP3" for GP3. The same happened to IO1/IO2. Please let me know if it is correct, I think it is the best way to not break stacks that already exist with these definitions.

@NetaNir 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mohanrajendran pushed a commit to mohanrajendran/aws-cdk that referenced this issue Jan 24, 2021
@leandrodamascena
feat(ec2): Support for new EBS types (aws#12074)
b9848d5 
closes aws#12071

Added new EBS types released in re:Invent 2020 and fixed some documentation problems.  Some observations:

./packages/@aws-cdk/aws-elasticsearch/lib/domain.ts - The Elasticsearch service allows only General Purpose, Provisioned IOPS and Magnetic. 
./packages/@aws-cdk/aws-rds/lib/instance.ts - Storage types and the official link were added

For compatibility reasons, I kept the " GENERAL_PURPOSE_SSD" as GP2 and created a new type called "GENERAL_PURPOSE_SSD_GP3" for GP3. The same happened to IO1/IO2. Please let me know if it is correct, I think it is the best way to not break stacks that already exist with these definitions.

@NetaNir 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ec2): Support for new EBS types leandrodamascena/aws-cdk
4 participants
@rix0rrr @leandrodamascena @NetaNir @SomayaB