Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElasticSearch: support V7_9 #12202

Closed
2 tasks
ce-tomas opened this issue Dec 22, 2020 · 2 comments · Fixed by #12222
Closed
2 tasks

ElasticSearch: support V7_9 #12202

ce-tomas opened this issue Dec 22, 2020 · 2 comments · Fixed by #12222
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md needs-triage This issue or PR still needs to be triaged.

Comments

@ce-tomas
Copy link

Although AWS supports the creation of ES domains with version 7.9 CDK only supports 7.7:
aws_elasticsearch.ElasticsearchVersion.V7_7 is max we can get as of Today (CDK 1.80)

Use Case

by simply adding enumerator ElasticsearchVersion.V7_9 to the aws_elasticsearch module people would be able to enjoy the benefits of the newer ES version.

Proposed Solution

add enum V7_9

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@ce-tomas ce-tomas added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 22, 2020
@NetaNir NetaNir added the @aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service label Dec 23, 2020
@NetaNir
Copy link
Contributor

NetaNir commented Dec 23, 2020

You can workaround this today by passing a version:

ElasticsearchVersion.of('7.9')

We can add it to the list of predefined types, happy to review a PR, should be added: https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/aws-elasticsearch/lib/domain.ts#L20

@NetaNir NetaNir added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md labels Dec 23, 2020
saudkhanzada pushed a commit to saudkhanzada/aws-cdk that referenced this issue Dec 24, 2020
feat(easticsearch): add support for version 7_8 and 7_9
6c6524f 
Closes aws#12202
@saudkhanzada saudkhanzada mentioned this issue Dec 24, 2020
Merged
saudkhanzada pushed a commit to saudkhanzada/aws-cdk that referenced this issue Dec 24, 2020
fix(easticsearch): add support for version 7_8 and 7_9
2aec0a5 
Fixes aws#12202
@mergify mergify bot closed this as completed in #12222 Dec 25, 2020
mergify bot pushed a commit that referenced this issue Dec 25, 2020
feat(elasticsearch): add support for version 7_8 and 7_9 (#12222)
09d1f6c 
closes #12202


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
@flochaz
feat(elasticsearch): add support for version 7_8 and 7_9 (aws#12222)
297bf97 
closes aws#12202


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-elasticsearch Related to Amazon Elasticsearch Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(elasticsearch): add support for version 7_8 and 7_9 saudkhanzada/aws-cdk
2 participants
@NetaNir @ce-tomas