Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-apigatewayv2): Support DisableExecuteApiEndpoint parameter #12241

Closed
kennu opened this issue Dec 27, 2020 · 3 comments · Fixed by #12426
Closed

(aws-apigatewayv2): Support DisableExecuteApiEndpoint parameter #12241

kennu opened this issue Dec 27, 2020 · 3 comments · Fixed by #12426
Assignees
@nija-at
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@kennu
Copy link

kennu commented Dec 27, 2020

CloudFormation AWS::ApiGatewayV2::Api supports a simple boolean DisableExecuteApiEndpoint parameter.

The DisableExecuteApiEndpoint parameter is missing from @aws-cdk/aws-apigatewayv2 HttpApi.

Environment

  • CDK CLI Version : 1.80.0
  • Framework Version: 1.80.0

This is 🐛 Bug Report
@kennu kennu added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 27, 2020
@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Dec 27, 2020
@kennu
Copy link
Author

kennu commented Dec 27, 2020

My simple escape hatch override for this is:

import { HttpApi, CfnApi } from '@aws-cdk/aws-apigatewayv2'
const httpApi = new HttpApi(this, 'HttpApi', { ... })
const cfnApi = httpApi.node.defaultChild as CfnApi
cfnApi.disableExecuteApiEndpoint = true

@nija-at nija-at added feature-request A feature should be added or improved. and removed bug This issue is a bug. labels Jan 7, 2021
@nija-at nija-at changed the title (aws-apigatewayv2): Missing DisableExecuteApiEndpoint parameter (aws-apigatewayv2): Support DisableExecuteApiEndpoint parameter Jan 7, 2021
@nija-at nija-at added p2 effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md and removed needs-triage This issue or PR still needs to be triaged. labels Jan 7, 2021
@rrhodes rrhodes mentioned this issue Jan 8, 2021
Merged
@rrhodes
Copy link
Contributor

rrhodes commented Jan 8, 2021

Hi @nija-at, @kennu, I've opened a PR to add support for DisableExecuteApiEndpoint parameter, hopefully have that merged in shortly for you.

@mergify mergify bot closed this as completed in #12426 Jan 14, 2021
mergify bot pushed a commit that referenced this issue Jan 14, 2021
@rrhodes
feat(apigatewayv2): http api - disable execute api endpoint (#12426)
1724da7 
Support DisableExecuteApiEndpoint property on HTTP APIs.

Closes #12241 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@NickIannelli NickIannelli mentioned this issue Jun 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(apigatewayv2): http api - disable execute api endpoint rrhodes/aws-cdk
3 participants
@kennu @rrhodes @nija-at