Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ec2): Add RDS VPC interface endpoints #12402

Assignees
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md needs-triage This issue or PR still needs to be triaged. p2

Comments

@choweiyuan
Copy link

Add RDS VPC interface endpoints

Use Case

VPC interface endpoints are supported for RDS, but don't exist in CDK:

https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/vpc-interface-endpoints.html

Proposed Solution

Add support for RDS VPC interface endpoints

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@choweiyuan choweiyuan added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 7, 2021
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Jan 7, 2021
@johnculkin
Copy link

johnculkin commented Jan 9, 2021

You can create interface endpoints with the CDK

Here is the method on the VPC Construct

https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-ec2.Vpc.html#addwbrinterfacewbrendpointid-options

Here is an example of creating a RDS endpoint in Python

vpc.add_interface_endpoint(
            'VPCRDSInterfaceEndpoint',
            service=ec2.InterfaceVpcEndpointAwsService('rds'), 
            private_dns_enabled=True,
            subnets=ec2.SubnetSelection(
                one_per_az=False,
                subnet_type=ec2.SubnetType.ISOLATED
            ),
)

@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 labels Jan 11, 2021
bcelenza added a commit to bcelenza/aws-cdk that referenced this issue Jan 13, 2021
rix0rrr pushed a commit to bcelenza/aws-cdk that referenced this issue Feb 9, 2021
rix0rrr pushed a commit to bcelenza/aws-cdk that referenced this issue Feb 25, 2021
@mergify mergify bot closed this as completed in #12497 Feb 26, 2021
mergify bot pushed a commit that referenced this issue Feb 26, 2021
Adds VPC endpoint support for RDS. Fixes #12402

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment