Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apigatewayv2): http api - disable execute api endpoint #12426

Merged
merged 7 commits into from
Jan 14, 2021
Merged

feat(apigatewayv2): http api - disable execute api endpoint #12426

merged 7 commits into from
Jan 14, 2021

Conversation

rrhodes
Copy link
Contributor

@rrhodes rrhodes commented Jan 8, 2021 •
edited
Loading

Support DisableExecuteApiEndpoint property on HTTP APIs.

Closes #12241

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 8, 2021 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Jan 8, 2021
@nija-at nija-at changed the title feat(apigatewayv2): support DisableExecuteApiEndpoint property on http apis #12241 feat(apigatewayv2): http api - disable execute api endpoint #12241 Jan 12, 2021
@nija-at nija-at changed the title feat(apigatewayv2): http api - disable execute api endpoint #12241 feat(apigatewayv2): http api - disable execute api endpoint Jan 12, 2021
nija-at
nija-at reviewed Jan 12, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR 😊 I have a question on this PR below.

packages/@aws-cdk/aws-apigatewayv2/README.md Outdated Show resolved Hide resolved
nija-at
nija-at previously requested changes Jan 13, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of minor suggestions.

packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/test/http/api.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apigatewayv2/lib/http/api.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed nija-at’s stale review January 13, 2021 18:45

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jan 14, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 14, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1724da7 into aws:master Jan 14, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4bd9160
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rrhodes rrhodes deleted the feature/12241-support-disable-execute-api-endpoint-on-http-apis branch January 14, 2021 11:08
@tvb
Copy link

tvb commented Apr 7, 2021

@rrhodes any reason why this is not available for aws_apigateway ?

@rrhodes
Copy link
Contributor Author

rrhodes commented Apr 7, 2021

Hi @tvb, no specific reason from me, simply wasn't in scope for the issue I was addressing here.

@tvb
Copy link

tvb commented Apr 7, 2021

@rrhodes would you be able to address the same for aws_apigateway?

It is now not possible to disable the execute api endpoint for the v1 API Gateway.

@rrhodes
Copy link
Contributor Author

rrhodes commented Apr 7, 2021

@tvb, you're welcome to raise an issue for someone to pick up. I did this contribution in my own time to help with other projects I'm working on.

@tvb
Copy link

tvb commented Apr 7, 2021

Gotcha, will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-apigatewayv2): Support DisableExecuteApiEndpoint parameter
4 participants
@rrhodes @aws-cdk-automation @tvb @nija-at