Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-ecs): Add support for ElasticInferenceAccelerators in ECS Task definitions #12460

Closed
2 tasks
TheEdgeOfCat opened this issue Jan 11, 2021 · 1 comment · Fixed by #13950
Closed
2 tasks

(aws-ecs): Add support for ElasticInferenceAccelerators in ECS Task definitions #12460

TheEdgeOfCat opened this issue Jan 11, 2021 · 1 comment · Fixed by #13950
Assignees
@upparekh
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. p2

Comments

@TheEdgeOfCat
Copy link

As I see it, currently the only way to create a task definition with elastic inference accelerators attached is by using the CfnTaskDefinition class directly, instead of the regular CDK construct (Ec2TaskDefinition).

Use Case

Use the Elastic Inference feature with ECS tasks through CDK.

Proposed solution

Add a inferenceAccelerators property to the Ec2TaskDefinition constructor typed as a list of InferenceAccelerator (or similar) struct class instances to pass the configuration parameters for each accelerator.

Once Fargate supports EIA, the property should also be added to the TaskDefinition and FargateTaskDefinition constructs.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@TheEdgeOfCat TheEdgeOfCat added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 11, 2021
@SoManyHs SoManyHs added @aws-cdk/aws-ecs Related to Amazon Elastic Container p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 12, 2021
@upparekh upparekh self-assigned this Mar 24, 2021
@upparekh upparekh mentioned this issue Apr 1, 2021
Merged
@ericzbeard ericzbeard added the feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs label Apr 2, 2021
@mergify mergify bot closed this as completed in #13950 Apr 15, 2021
mergify bot pushed a commit that referenced this issue Apr 15, 2021
@upparekh
feat(ecs): add support for elastic inference accelerators in ECS task…
23986d7 
… defintions (#13950)

This PR would enable users to attach inference accelerators to their ECS tasks (currently not supported by Fargate). It adds an optional `inferenceAccelerators` property to the EC2 Task Definition. It also adds `resourceRequirement` property to the Container definition to enable containers to refer to the inference accelerators provided in the task definition.  

Closes #12460 

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@upparekh @hollanddd
feat(ecs): add support for elastic inference accelerators in ECS task…
a37d277 
… defintions (aws#13950)

This PR would enable users to attach inference accelerators to their ECS tasks (currently not supported by Fargate). It adds an optional `inferenceAccelerators` property to the EC2 Task Definition. It also adds `resourceRequirement` property to the Container definition to enable containers to refer to the inference accelerators provided in the task definition.  

Closes aws#12460 

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@upparekh upparekh

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container effort/small Small work item – less than a day of effort feature/coverage-gap Gaps in CloudFormation coverage by L2 constructs feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ecs): add support for elastic inference accelerators in ECS task defintions upparekh/aws-cdk
4 participants
@ericzbeard @SoManyHs @TheEdgeOfCat @upparekh